Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: Fixed handling of 'radio' module parameter from module_param_array to module_param_named to fix these compiler warnings in cx18-driver.c: NACK. radio is an array of tristate values (-1, 0, 1) per installed card: static int

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: Fixed handling of 'radio' module parameter from module_param_array to module_param_named to fix these compiler warnings in cx18-driver.c: NACK. radio is an array of tristate

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Danny Kukawka
On Dienstag, 31. Januar 2012, Andy Walls wrote: On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: Fixed handling of 'radio' module parameter from module_param_array to module_param_named to fix these compiler warnings in

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
Danny Kukawka danny.kuka...@bisect.de wrote: On Dienstag, 31. Januar 2012, Andy Walls wrote: On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: Fixed handling of 'radio' module parameter from module_param_array to

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Rusty Russell
On Tue, 31 Jan 2012 14:45:18 +0100, Danny Kukawka danny.kuka...@bisect.de wrote: On Dienstag, 31. Januar 2012, Andy Walls wrote: Overseen this. But wouldn't be the correct fix in this case to: a) reverse the part of 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to: get: static unsigned

[PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-30 Thread Danny Kukawka
Fixed handling of 'radio' module parameter from module_param_array to module_param_named to fix these compiler warnings in cx18-driver.c: In function ‘__check_radio’: 113:1: warning: return from incompatible pointer type [enabled by default] At top level: 113:1: warning: initialization from