Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-13 Thread Manu Abraham
On Tue, Jan 12, 2010 at 3:28 PM, Jiri Slaby wrote: > On 01/12/2010 12:48 AM, Andy Walls wrote: >> On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote: >>> Stanse found a potential null dereference in cx18_dvb_start_feed >>> and cx18_dvb_stop_feed. There is a check for stream being NULL, >>> but it

Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-13 Thread Jiri Slaby
On 01/13/2010 12:32 PM, Andy Walls wrote: > If you don't mind a delay of until Sunday or so to get the patch applied > to the V4L-DVB tree, I can take the patch and work it in my normal path > through Mauro. Let me know. I have no problem with that. thanks, -- js -- To unsubscribe from this lis

Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-13 Thread Andy Walls
On Tue, 2010-01-12 at 12:28 +0100, Jiri Slaby wrote: > On 01/12/2010 12:48 AM, Andy Walls wrote: > > On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote: > >> Stanse found a potential null dereference in cx18_dvb_start_feed > >> and cx18_dvb_stop_feed. There is a check for stream being NULL, > >> b

Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-12 Thread Jiri Slaby
On 01/12/2010 12:48 AM, Andy Walls wrote: > On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote: >> Stanse found a potential null dereference in cx18_dvb_start_feed >> and cx18_dvb_stop_feed. There is a check for stream being NULL, >> but it is dereferenced earlier. Move the dereference after the >

Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-11 Thread Andy Walls
On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote: > Stanse found a potential null dereference in cx18_dvb_start_feed > and cx18_dvb_stop_feed. There is a check for stream being NULL, > but it is dereferenced earlier. Move the dereference after the > check. > > Signed-off-by: Jiri Slaby Review

[PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-10 Thread Jiri Slaby
Stanse found a potential null dereference in cx18_dvb_start_feed and cx18_dvb_stop_feed. There is a check for stream being NULL, but it is dereferenced earlier. Move the dereference after the check. Signed-off-by: Jiri Slaby --- drivers/media/video/cx18/cx18-dvb.c | 18 ++ 1 fi