Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-07-03 Thread Hans Verkuil
On Thursday 02 July 2009 22:32:38 m-kariche...@ti.com wrote: From: Muralidharan Karicheri m-kariche...@ti.com Re-sending to add description (and also experimental status) for VPFE_CMD_S_CCDC_RAW_PARAMS and updating debug prints with \n and fixing an error coder ENOMEM VPFE Capture bridge

Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-07-02 Thread Hans Verkuil
On Thursday 02 July 2009 19:05:51 m-kariche...@ti.com wrote: From: Muralidharan Karicheri m-kariche...@ti.com Re-sending to add description for VPFE_CMD_S_CCDC_RAW_PARAMS and updating debug prints with \n and fixing an error coder ENOMEM VPFE Capture bridge driver This is version, v3 of

RE: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-07-02 Thread Karicheri, Muralidharan
Hans, snip I've only one request: can you add something along the lines of: This is an experimental ioctl that will change in future kernels. Use with care. And at the top add: EXPERIMENTAL IOCTL That way it is unambiguous that this will change. And it definitely has to change! On the other

RE: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-06-22 Thread Karicheri, Muralidharan
, Muralidharan; linux-media@vger.kernel.org; davinci-linux- open-sou...@linux.davincidsp.com Subject: Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446 On Wednesday 17 June 2009 23:29:31 Alexey Klimov wrote: Hello, very small comments, see below please Thanks, I've added

Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-06-19 Thread Hans Verkuil
On Wednesday 17 June 2009 23:29:31 Alexey Klimov wrote: Hello, very small comments, see below please Thanks, I've added the missing newlines and the wrong return code in a separate patch in my pull request. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by

Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-06-17 Thread Alexey Klimov
Hello, very small comments, see below please On Thu, Jun 18, 2009 at 12:11 AM, m-kariche...@ti.com wrote: From: Muralidharan Karicheri m-kariche...@ti.com snip +static int vpfe_enable_clock(struct vpfe_device *vpfe_dev) +{ +       struct vpfe_config *vpfe_cfg = vpfe_dev-cfg; +       int