Re: [PATCH 1/2] V4L/DVB: buf-dma-sg.c: don't assume nr_pages == sglen

2010-03-30 Thread Arnout Vandecappelle
On Wednesday 24 March 2010 06:43:22, Sakari Ailus wrote: > Hi Arnout, > > Thanks for the patch. > > Arnout Vandecappelle wrote: [snip] > > - dma_sync_sg_for_cpu(q->dev, dma->sglist, dma->nr_pages, > > dma->direction); > > + dma_sync_sg_for_cpu(q->dev, dma->sglist, dma->sglen, dma->directio

Re: [PATCH 1/2] V4L/DVB: buf-dma-sg.c: don't assume nr_pages == sglen

2010-03-23 Thread Sakari Ailus
Hi Arnout, Thanks for the patch. Arnout Vandecappelle wrote: > videobuf_pages_to_sg() and videobuf_vmalloc_to_sg() happen to create > a scatterlist element for every page. However, this is not true for > bus addresses, so other functions shouldn't rely on the length of the > scatter list being e

[PATCH 1/2] V4L/DVB: buf-dma-sg.c: don't assume nr_pages == sglen

2010-03-17 Thread Arnout Vandecappelle
videobuf_pages_to_sg() and videobuf_vmalloc_to_sg() happen to create a scatterlist element for every page. However, this is not true for bus addresses, so other functions shouldn't rely on the length of the scatter list being equal to nr_pages. --- drivers/media/video/videobuf-dma-sg.c |4 ++-

Re: [PATCH 1/2] V4L/DVB: buf-dma-sg.c: don't assume nr_pages == sglen

2010-03-17 Thread Arnout Vandecappelle
On Wednesday 17 March 2010 21:57:18, Sakari Ailus wrote: > Arnout Vandecappelle wrote: > > diff --git a/drivers/media/video/videobuf-dma-sg.c > > b/drivers/media/video/videobuf-dma-sg.c index da1790e..3b6f1b8 100644 > > --- a/drivers/media/video/videobuf-dma-sg.c > > +++ b/drivers/media/video/vide

Re: [PATCH 1/2] V4L/DVB: buf-dma-sg.c: don't assume nr_pages == sglen

2010-03-17 Thread Sakari Ailus
Hi Arnout, Arnout Vandecappelle wrote: > videobuf_pages_to_sg() and videobuf_vmalloc_to_sg() happen to create > a scatterlist element for every page. However, this is not true for > bus addresses, so other functions shouldn't rely on the length of the > scatter list being equal to nr_pages. > ---

[PATCH 1/2] V4L/DVB: buf-dma-sg.c: don't assume nr_pages == sglen

2010-03-04 Thread Arnout Vandecappelle
videobuf_pages_to_sg() and videobuf_vmalloc_to_sg() happen to create a scatterlist element for every page. However, this is not true for bus addresses, so other functions shouldn't rely on the length of the scatter list being equal to nr_pages. --- drivers/media/video/videobuf-dma-sg.c |6 +++