Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-14 Thread Josh Wu
On 1/12/2015 6:38 PM, Laurent Pinchart wrote: Hi Josh, On Monday 12 January 2015 17:14:33 Josh Wu wrote: On 1/9/2015 6:47 AM, Laurent Pinchart wrote: On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote: On Wed, 7 Jan 2015, Josh Wu wrote: On 1/7/2015 6:17 AM, Guennadi

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-12 Thread Josh Wu
Hi, Guennadi and Laurent On 1/9/2015 6:47 AM, Laurent Pinchart wrote: Hi Guennadi and Josh, On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote: On Wed, 7 Jan 2015, Josh Wu wrote: On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote: On Tue, 6 Jan 2015, Josh Wu wrote: Hi, Guennadi

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-12 Thread Laurent Pinchart
Hi Josh, On Monday 12 January 2015 17:14:33 Josh Wu wrote: On 1/9/2015 6:47 AM, Laurent Pinchart wrote: On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote: On Wed, 7 Jan 2015, Josh Wu wrote: On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote: On Tue, 6 Jan 2015, Josh Wu

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-08 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 7 Jan 2015, Josh Wu wrote: Hi, Guennadi On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote: Hi Josh, On Tue, 6 Jan 2015, Josh Wu wrote: Hi, Guennadi After look deep into this patch, I found you miss one line that should be changed as well. It's In

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-08 Thread Laurent Pinchart
Hi Guennadi and Josh, On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote: On Wed, 7 Jan 2015, Josh Wu wrote: On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote: On Tue, 6 Jan 2015, Josh Wu wrote: Hi, Guennadi After look deep into this patch, I found you miss one line that

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-06 Thread Josh Wu
Hi, Guennadi After look deep into this patch, I found you miss one line that should be changed as well. It's In function v4l2_clk_get(), there still has one line code called v4l2_clk_find(dev_id, id). You need to change it to v4l2_clk_find(dev_id, NULL) as well. Otherwise the code that many

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-06 Thread Guennadi Liakhovetski
Hi Josh, On Tue, 6 Jan 2015, Josh Wu wrote: Hi, Guennadi After look deep into this patch, I found you miss one line that should be changed as well. It's In function v4l2_clk_get(), there still has one line code called v4l2_clk_find(dev_id, id). You need to change it to

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-06 Thread Josh Wu
Hi, Guennadi On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote: Hi Josh, On Tue, 6 Jan 2015, Josh Wu wrote: Hi, Guennadi After look deep into this patch, I found you miss one line that should be changed as well. It's In function v4l2_clk_get(), there still has one line code called

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-06 Thread Josh Wu
Hi, Guennadi On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote: Hi Josh, On Tue, 6 Jan 2015, Josh Wu wrote: Hi, Guennadi After look deep into this patch, I found you miss one line that should be changed as well. It's In function v4l2_clk_get(), there still has one line code called

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-05 Thread Guennadi Liakhovetski
Hi Josh, On Mon, 5 Jan 2015, Josh Wu wrote: Hi, Guennadi On 1/2/2015 7:48 PM, Guennadi Liakhovetski wrote: All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which also will make CCF and DT integration easier. This patch not

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-05 Thread Josh Wu
Hi, Guennadi On 1/5/2015 5:28 PM, Guennadi Liakhovetski wrote: Hi Josh, On Mon, 5 Jan 2015, Josh Wu wrote: Hi, Guennadi On 1/2/2015 7:48 PM, Guennadi Liakhovetski wrote: All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-05 Thread Josh Wu
Hi, Guennadi On 1/2/2015 7:48 PM, Guennadi Liakhovetski wrote: All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which also will make CCF and DT integration easier. This patch not register a v4l2_clk with name: mclk. So this will

[PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-02 Thread Guennadi Liakhovetski
All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which also will make CCF and DT integration easier. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/platform/soc_camera/soc_camera.c | 6 +++---