Re: [PATCH 1/2] v4l2-core: Simplify v4l2_m2m_try_{schedule,run}

2018-07-19 Thread Ezequiel Garcia
On Wed, 2018-07-18 at 12:23 +0200, Hans Verkuil wrote: > On 12/07/18 17:43, Ezequiel Garcia wrote: > > v4l2_m2m_try_run() has only one caller and so it's possible > > to move its contents. > > > > Although this de-modularization change could reduce clarity, > > in this case it allows to remove a s

Re: [PATCH 1/2] v4l2-core: Simplify v4l2_m2m_try_{schedule,run}

2018-07-18 Thread Hans Verkuil
On 12/07/18 17:43, Ezequiel Garcia wrote: > v4l2_m2m_try_run() has only one caller and so it's possible > to move its contents. > > Although this de-modularization change could reduce clarity, > in this case it allows to remove a spinlock lock/unlock pair > and an unneeded sanity check. > > Signe

[PATCH 1/2] v4l2-core: Simplify v4l2_m2m_try_{schedule,run}

2018-07-12 Thread Ezequiel Garcia
v4l2_m2m_try_run() has only one caller and so it's possible to move its contents. Although this de-modularization change could reduce clarity, in this case it allows to remove a spinlock lock/unlock pair and an unneeded sanity check. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4