Re: [PATCH 14/14] [media] gspca: Use current logging styles

2011-08-22 Thread Jean-Francois Moine
On Sun, 21 Aug 2011 15:56:57 -0700 Joe Perches j...@perches.com wrote: Add pr_fmt. Convert usb style logging macros to pr_level. Remove now unused old usb style logging macros. Hi Joe, Sorry, but I do not see the advantages of your patch. For gspca, the source files are bigger, and the only

Re: [PATCH 14/14] [media] gspca: Use current logging styles

2011-08-22 Thread Joe Perches
On Mon, 2011-08-22 at 10:50 +0200, Jean-Francois Moine wrote: On Sun, 21 Aug 2011 15:56:57 -0700 Joe Perches j...@perches.com wrote: Add pr_fmt. Convert usb style logging macros to pr_level. Remove now unused old usb style logging macros. Hi Joe, Hello Jean-Francois. Sorry, but I do

Re: [PATCH 14/14] [media] gspca: Use current logging styles

2011-08-22 Thread Jean-Francois Moine
On Mon, 22 Aug 2011 08:20:28 -0700 Joe Perches j...@perches.com wrote: The primary current advantage is style standardization both in code and dmesg output. Future changes to printk.h will reduce object sizes by centralizing the prefix to a singleton and emitting it only in pr_level. Hi