[PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-09 Thread Frank Schäfer
The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer --- lib/libv4lconvert/control/libv4lcontrol.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcont

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-09 Thread Hans de Goede
Hi, On 09/09/2012 08:36 PM, Frank Schäfer wrote: The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer --- lib/libv4lconvert/control/libv4lcontrol.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/libv4lconvert/control/l

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-10 Thread Frank Schäfer
Am 09.09.2012 23:24, schrieb Hans de Goede: > Hi, > > On 09/09/2012 08:36 PM, Frank Schäfer wrote: >> The gspca_pac7302 driver already provides this control. >> >> Signed-off-by: Frank Schäfer >> --- >> lib/libv4lconvert/control/libv4lcontrol.c | 12 >> 1 files changed, 4 inserti

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-10 Thread Hans de Goede
Hi, On 09/10/2012 05:41 PM, Frank Schäfer wrote: Am 09.09.2012 23:24, schrieb Hans de Goede: Hi, On 09/09/2012 08:36 PM, Frank Schäfer wrote: The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer --- lib/libv4lconvert/control/libv4lcontrol.c | 12

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-10 Thread Frank Schäfer
Am 10.09.2012 20:33, schrieb Hans de Goede: > Hi, > > On 09/10/2012 05:41 PM, Frank Schäfer wrote: >> Am 09.09.2012 23:24, schrieb Hans de Goede: >>> Hi, >>> >>> On 09/09/2012 08:36 PM, Frank Schäfer wrote: The gspca_pac7302 driver already provides this control. Signed-off-by: Frank

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-11 Thread Hans de Goede
Hi, On 09/10/2012 10:33 PM, Frank Schäfer wrote: And if AWB is on, the WB control should be disabled, right ? No, the software AWB works by applying software rgb gains, so the hardware control is still useful, as the better the color balance of the input, the better the end-result will be.