Re: [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control

2012-09-21 Thread Anatolij Gustschin
On Fri, 24 Aug 2012 16:32:57 +0200 (CEST) Guennadi Liakhovetski wrote: ... > > > But why do we have to write it here at all then? Autoexposure can be off > > > only if the user has set exposure manually, using V4L2_CID_EXPOSURE_AUTO. > > > In this case MT9V022_TOTAL_SHUTTER_WIDTH already contain

Re: [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control

2012-08-24 Thread Guennadi Liakhovetski
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > Hi Guennadi, > > On Fri, 24 Aug 2012 13:22:18 +0200 (CEST) > Guennadi Liakhovetski wrote: > ... > > > --- a/drivers/media/i2c/soc_camera/mt9v022.c > > > +++ b/drivers/media/i2c/soc_camera/mt9v022.c > > > @@ -274,9 +274,9 @@ static int mt9v022_s_cr

Re: [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control

2012-08-24 Thread Anatolij Gustschin
Hi Guennadi, On Fri, 24 Aug 2012 13:22:18 +0200 (CEST) Guennadi Liakhovetski wrote: ... > > --- a/drivers/media/i2c/soc_camera/mt9v022.c > > +++ b/drivers/media/i2c/soc_camera/mt9v022.c > > @@ -274,9 +274,9 @@ static int mt9v022_s_crop(struct v4l2_subdev *sd, > > struct v4l2_crop *a) > >

Re: [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control

2012-08-24 Thread Guennadi Liakhovetski
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > Since the MT9V022_TOTAL_SHUTTER_WIDTH register is controlled in manual > mode by V4L2_CID_EXPOSURE control, it shouldn't be written directly in > mt9v022_s_crop(). In manual mode this register should be set to the > V4L2_CID_EXPOSURE control value.

[PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control

2012-08-24 Thread Anatolij Gustschin
Since the MT9V022_TOTAL_SHUTTER_WIDTH register is controlled in manual mode by V4L2_CID_EXPOSURE control, it shouldn't be written directly in mt9v022_s_crop(). In manual mode this register should be set to the V4L2_CID_EXPOSURE control value. Changing this register directly and outside of the actua