Re: [PATCH 2/3] smiapp: Check for GPIO validity using gpio_is_valid()

2014-05-09 Thread Sakari Ailus
Hi Laurent, On Fri, May 09, 2014 at 02:18:24PM +0200, Laurent Pinchart wrote: > On Sunday 04 May 2014 03:31:56 Sakari Ailus wrote: > > Do not use our special value, SMIAPP_NO_XSHUTDOWN. > > > > Signed-off-by: Sakari Ailus > > Wouldn't it make sense to switch to the gpiod API ? That change could

Re: [PATCH 2/3] smiapp: Check for GPIO validity using gpio_is_valid()

2014-05-09 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Sunday 04 May 2014 03:31:56 Sakari Ailus wrote: > Do not use our special value, SMIAPP_NO_XSHUTDOWN. > > Signed-off-by: Sakari Ailus Wouldn't it make sense to switch to the gpiod API ? That change could then replace this patch. If you would like to do so

[PATCH 2/3] smiapp: Check for GPIO validity using gpio_is_valid()

2014-05-03 Thread Sakari Ailus
Do not use our special value, SMIAPP_NO_XSHUTDOWN. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c index c1d6d1