Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

2014-12-14 Thread Antti Palosaari
On 12/13/2014 08:52 PM, Benjamin Larsson wrote: On 12/13/2014 02:35 PM, Antti Palosaari wrote: Do you understand that code at all? No I can't really say I understand all the workings of the media api. Now it is: FE0 == (fe-id == 0) == RTL2832 FE1 == (fe-id == 1) == MN88472 you changed

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

2014-12-13 Thread Benjamin Larsson
On 12/13/2014 05:02 AM, Antti Palosaari wrote: I am not sure even idea of that. You didn't add even commit description, like all the other patches too :( You should really start adding commit messages explaining why and how commit is. So the question is why that patch should be applied?

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

2014-12-13 Thread Antti Palosaari
On 12/13/2014 01:09 PM, Benjamin Larsson wrote: On 12/13/2014 05:02 AM, Antti Palosaari wrote: I am not sure even idea of that. You didn't add even commit description, like all the other patches too :( You should really start adding commit messages explaining why and how commit is. So the

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

2014-12-13 Thread Benjamin Larsson
On 12/13/2014 02:35 PM, Antti Palosaari wrote: Do you understand that code at all? No I can't really say I understand all the workings of the media api. Now it is: FE0 == (fe-id == 0) == RTL2832 FE1 == (fe-id == 1) == MN88472 you changed it to: FE0 == (fe-id == 0) == MN88472 FE1 ==

[PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

2014-12-12 Thread Benjamin Larsson
Signed-off-by: Benjamin Larsson benja...@southpole.se --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index ab48b5f..cdc342a 100644 ---

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

2014-12-12 Thread Antti Palosaari
I am not sure even idea of that. You didn't add even commit description, like all the other patches too :( You should really start adding commit messages explaining why and how commit is. So the question is why that patch should be applied? On the other-hand, how there is if (fe-id == 1