Re: [PATCH 2/5] v4l: flash: Make v4l2_flash_init() and v4l2_flash_release() functions always

2015-05-23 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Wednesday 20 May 2015 02:04:02 Sakari Ailus wrote: If CONFIG_V4L2_FLASH_LED_CLASS wasn't defined, v4l2_flash_init() and v4l2_flash_release() were empty macros. This will lead to compiler warnings in form of unused variables if the variables are not used

[PATCH 2/5] v4l: flash: Make v4l2_flash_init() and v4l2_flash_release() functions always

2015-05-19 Thread Sakari Ailus
If CONFIG_V4L2_FLASH_LED_CLASS wasn't defined, v4l2_flash_init() and v4l2_flash_release() were empty macros. This will lead to compiler warnings in form of unused variables if the variables are not used for other purposes. Instead, implement v4l2_flash_init() and v4l2_flash_release() as static