Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-27 Thread Kassey Lee
2011/6/23 Jonathan Corbet : > [Sorry, I'm just now recovering from one of those > total-loss-of-inbox-control episodes...] > > On Fri, 17 Jun 2011 11:11:33 +0800 > Kassey Lee wrote: > >>      the problem is: >>      when we stop CCIC, and then switch to another format. >>      at this stage, actua

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-22 Thread Jonathan Corbet
[Sorry, I'm just now recovering from one of those total-loss-of-inbox-control episodes...] On Fri, 17 Jun 2011 11:11:33 +0800 Kassey Lee wrote: > the problem is: > when we stop CCIC, and then switch to another format. > at this stage, actually, CCIC DMA is not stopped until the >

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-16 Thread Kassey Lee
2011/6/16 Jonathan Corbet : > On Thu, 16 Jun 2011 11:12:03 +0800 > Kassey Lee wrote: > >>       2) for mcam_ctlr_stop_dma implementation, I guess you know >> something about the silicon limitation,  but we found it can not pass >> our stress test(1000 times capture test, which will switch format >

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-16 Thread Kassey Lee
2011/6/17 Mauro Carvalho Chehab : > Em 15-06-2011 23:30, Kassey Lee escreveu: >> 2011/6/14 Jonathan Corbet : >>> On Tue, 14 Jun 2011 10:58:47 +0800 >>> Kassey Lee wrote: > +       /* > +        * Try to find the sensor. > +        */ > +       cam->sensor_addr = ov7670_info.addr; >

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-16 Thread Mauro Carvalho Chehab
Em 16-06-2011 12:27, Jonathan Corbet escreveu: > On Thu, 16 Jun 2011 11:12:03 +0800 > Kassey Lee wrote: > >> 2) for mcam_ctlr_stop_dma implementation, I guess you know >> something about the silicon limitation, but we found it can not pass >> our stress test(1000 times capture test, which

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-16 Thread Mauro Carvalho Chehab
Em 15-06-2011 23:30, Kassey Lee escreveu: > 2011/6/14 Jonathan Corbet : >> On Tue, 14 Jun 2011 10:58:47 +0800 >> Kassey Lee wrote: + /* +* Try to find the sensor. +*/ + cam->sensor_addr = ov7670_info.addr; + cam->sensor = v4l2_i2c_new_subd

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-16 Thread Jonathan Corbet
On Thu, 16 Jun 2011 11:12:03 +0800 Kassey Lee wrote: > 2) for mcam_ctlr_stop_dma implementation, I guess you know > something about the silicon limitation, but we found it can not pass > our stress test(1000 times capture test, which will switch format > between JPEG and YUV again and agai

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-15 Thread Kassey Lee
Jon: after review your code: 1) here is the code, that deal with controller we can share.but still need to tune. 2) for mcam_ctlr_stop_dma implementation, I guess you know something about the silicon limitation, but we found it can not pass our stress test(1000 times capture tes

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-15 Thread Kassey Lee
2011/6/14 Jonathan Corbet : > On Tue, 14 Jun 2011 10:58:47 +0800 > Kassey Lee wrote: > >> > +#include >> > +#include >> > +#include >> > + >> Would be good to sort headers alphabetically > > Um, I suppose.  You're sure you don't want inverse Christmas-tree ordering? > :) > >> > +static int cafe

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-14 Thread Jonathan Corbet
On Tue, 14 Jun 2011 10:58:47 +0800 Kassey Lee wrote: > > +#include > > +#include > > +#include > > + > Would be good to sort headers alphabetically Um, I suppose. You're sure you don't want inverse Christmas-tree ordering? :) > > +static int cafe_smbus_write_done(struct mcam_camera *mcam) >