Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-12 Thread Kassey Lee
Yes, thank you very much! 2011/4/12 Guennadi Liakhovetski : > On Tue, 12 Apr 2011, Kassey Lee wrote: > >> 2011/4/12 Kassey Lee : >> > Hi, Guennadi; >> >           for sizeimage , I agree with you. that we can overwrite it >> > after a frame is done. >> > >> >    for byteperline: on Marvell soc. >>

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-12 Thread Guennadi Liakhovetski
On Tue, 12 Apr 2011, Kassey Lee wrote: > 2011/4/12 Kassey Lee : > > Hi, Guennadi; > >           for sizeimage , I agree with you. that we can overwrite it > > after a frame is done. > > > >    for byteperline: on Marvell soc. > >    it needs to know the bytesperline before receive frame from senso

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-12 Thread Kassey Lee
2011/4/12 Kassey Lee : > Hi, Guennadi; >           for sizeimage , I agree with you. that we can overwrite it > after a frame is done. > >    for byteperline: on Marvell soc. >    it needs to know the bytesperline before receive frame from sensor. >    what we did now is hardcode  in host driver fo

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-12 Thread Sylwester Nawrocki
Hi, On 04/12/2011 08:28 AM, Guennadi Liakhovetski wrote: > Hi > > On Tue, 12 Apr 2011, Kassey Lee wrote: > >> hi, Guennadi: >> a lot of sensors support JPEG output. >> 1) bytesperline is defined by sensor timing. Im not sure whether this is the case. Doesn't bytesperline refer only to

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-11 Thread Guennadi Liakhovetski
Hi On Tue, 12 Apr 2011, Kassey Lee wrote: > hi, Guennadi: > a lot of sensors support JPEG output. > 1) bytesperline is defined by sensor timing. > 2) and sizeimage is unknow for jpeg. > > how about for JPEG >1) host driver gets bytesperline from sensor driver. >2) sizeimage

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-11 Thread Kassey Lee
hi, Guennadi: a lot of sensors support JPEG output. 1) bytesperline is defined by sensor timing. 2) and sizeimage is unknow for jpeg. how about for JPEG 1) host driver gets bytesperline from sensor driver. 2) sizeimage refilled by host driver after dma transfer done( a frame is

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-11 Thread Guennadi Liakhovetski
On Mon, 11 Apr 2011, Janusz Krzysztofik wrote: > Dnia niedziela 10 kwiecień 2011 o 18:00:14 Guennadi Liakhovetski > napisał(a): > > Hi Janusz > > > > On Sat, 9 Apr 2011, Janusz Krzysztofik wrote: > > > Since commit 0e4c180d3e2cc11e248f29d4c604b6194739d05a, bytesperline > > > and sizeimage memebe

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-10 Thread Guennadi Liakhovetski
On Mon, 11 Apr 2011, Janusz Krzysztofik wrote: > Dnia niedziela 10 kwiecień 2011 o 18:00:14 Guennadi Liakhovetski > napisał(a): > > Hi Janusz > > > > On Sat, 9 Apr 2011, Janusz Krzysztofik wrote: > > > Since commit 0e4c180d3e2cc11e248f29d4c604b6194739d05a, bytesperline > > > and sizeimage memebe

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-10 Thread Janusz Krzysztofik
Dnia niedziela 10 kwiecień 2011 o 18:00:14 Guennadi Liakhovetski napisał(a): > Hi Janusz > > On Sat, 9 Apr 2011, Janusz Krzysztofik wrote: > > Since commit 0e4c180d3e2cc11e248f29d4c604b6194739d05a, bytesperline > > and sizeimage memebers of v4l2_pix_format structure have no longer > > been calcul

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-10 Thread Guennadi Liakhovetski
Hi Janusz On Sat, 9 Apr 2011, Janusz Krzysztofik wrote: > Since commit 0e4c180d3e2cc11e248f29d4c604b6194739d05a, bytesperline and > sizeimage memebers of v4l2_pix_format structure have no longer been > calculated inside soc_camera_g_fmt_vid_cap(), but rather passed via > soc_camera_device stru

[PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-08 Thread Janusz Krzysztofik
Since commit 0e4c180d3e2cc11e248f29d4c604b6194739d05a, bytesperline and sizeimage memebers of v4l2_pix_format structure have no longer been calculated inside soc_camera_g_fmt_vid_cap(), but rather passed via soc_camera_device structure from a host driver callback invoked by soc_camera_set_fmt()