Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: ... > +static int cio2_pci_probe(struct pci_dev *pci_dev, > + const struct pci_device_id *id) > +{ > + struct cio2_device *cio2; > + phys_addr_t phys; > + void __iomem *const *iomap; > + int i

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, On Wed, May 10, 2017 at 12:27 AM, Tomasz Figa wrote: > On Tue, May 2, 2017 at 9:00 PM, Sakari Ailus wrote: >> Hi Yong, >> >> Thanks for the patches! Some comments below. >> >> On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: >>> + >>>

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

On Tue, May 2, 2017 at 9:00 PM, Sakari Ailus wrote: > Hi Yong, > > Thanks for the patches! Some comments below. > > On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: >> + >> +/ FBPT operations / >> + >> +static void

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Hans, On Mon, May 08, 2017 at 03:08:26PM +0200, Hans Verkuil wrote: > On 05/08/2017 02:56 PM, Sakari Ailus wrote: ... > >> The USERPTR mode is more dubious. Has this been tested? Can the DMA handle > >> partially > >> filled pages? (I.e. there must be no requirements such as that the DMA has

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

On 05/08/2017 02:56 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, May 08, 2017 at 02:32:22PM +0200, Hans Verkuil wrote: >> On 05/08/2017 02:10 PM, Sakari Ailus wrote: > > ... > > +/* .complete() is called after all subdevices have been located */ > +static int

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Hans, On Mon, May 08, 2017 at 02:32:22PM +0200, Hans Verkuil wrote: > On 05/08/2017 02:10 PM, Sakari Ailus wrote: ... > >>> +/* .complete() is called after all subdevices have been located */ > >>> +static int cio2_notifier_complete(struct v4l2_async_notifier *notifier) > >>> +{ > >>> +

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

On 05/08/2017 02:10 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, May 08, 2017 at 11:06:29AM +0200, Hans Verkuil wrote: > ... >>> +static void cio2_queue_event_sof(struct cio2_device *cio2, struct >>> cio2_queue *q) >>> +{ >>> + struct v4l2_event event = { >>> + .type =

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Hans, On Mon, May 08, 2017 at 11:06:29AM +0200, Hans Verkuil wrote: ... > > +static void cio2_queue_event_sof(struct cio2_device *cio2, struct > > cio2_queue *q) > > +{ > > + struct v4l2_event event = { > > + .type = V4L2_EVENT_FRAME_SYNC, > > +

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong Zhi, See my review comments below. Nothing earth-shattering, you'll be pleased to hear :-) On 04/30/2017 01:34 AM, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > The V4L2 fwnode matching depends on the following work: > >

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Hans, Hans Verkuil wrote: Is it likely that there will be more Intel PCI drivers? If so, then we can consider putting it in pci/intel/ipu3/. Maybe. There is more hardware and they're called IPUs, too. I think this naming would be a good idea going forward. -- Regards, Sakari Ailus

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

On 04/30/2017 01:34 AM, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > The V4L2 fwnode matching depends on the following work: > > > > Signed-off-by: Yong Zhi

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Tuukka, On Wed, May 03, 2017 at 02:06:23PM +0300, Tuukka Toivonen wrote: > Hi Sakari, > > On Wednesday, May 03, 2017 11:58:01 Sakari Ailus wrote: > > Hi Yong, > > > > A few more minor comments below... > > > > On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: > > ... > > > +/***

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Moi, On Wed, May 03, 2017 at 01:57:31PM +0300, Tuukka Toivonen wrote: > Hi Sakari, > > Thanks for the comments. > > On Tuesday, May 02, 2017 16:00:20 Sakari Ailus wrote: > > Hi Yong, > > > > Thanks for the patches! Some comments below. > > > > On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Sakari, On Wednesday, May 03, 2017 11:58:01 Sakari Ailus wrote: > Hi Yong, > > A few more minor comments below... > > On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: > ... > > +/*** V4L2 sub-device asynchronous registration callbacks***/ > > + > > +static struct

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Sakari, Thanks for the comments. On Tuesday, May 02, 2017 16:00:20 Sakari Ailus wrote: > Hi Yong, > > Thanks for the patches! Some comments below. > > On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: > > This patch adds CIO2 CSI-2 device driver for > > Intel's IPU3 camera

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, A few more minor comments below... On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: ... > +/*** V4L2 sub-device asynchronous registration callbacks***/ > + > +static struct cio2_queue *cio2_find_queue_by_sensor_node(struct cio2_queue > *q, > +

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, Thanks for the patches! Some comments below. On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > The V4L2 fwnode matching depends on the following work: > >

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170428] [cannot apply to v4.11-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

This patch adds CIO2 CSI-2 device driver for Intel's IPU3 camera sub-system support. The V4L2 fwnode matching depends on the following work: Signed-off-by: Yong Zhi --- drivers/media/pci/Kconfig