Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-06-10 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, > > On Monday 16 May 2011 15:00:39 Sakari Ailus wrote: >> This patch adds the driver for the adp1653 LED flash controller. This >> controller supports a high power led in flash and torch modes and an >> indicator light, sometimes also called privacy light. >> >

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-06-09 Thread Laurent Pinchart
Hi Sakari, On Monday 16 May 2011 15:00:39 Sakari Ailus wrote: > This patch adds the driver for the adp1653 LED flash controller. This > controller supports a high power led in flash and torch modes and an > indicator light, sometimes also called privacy light. > > The adp1653 is used on the Nokia

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-22 Thread Sakari Ailus
Mauro Carvalho Chehab wrote: > Em 19-05-2011 07:41, Sakari Ailus escreveu: >> This patch adds the driver for the adp1653 LED flash controller. This >> controller supports a high power led in flash and torch modes and an >> indicator light, sometimes also called privacy light. >> >> The adp1653 is u

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-21 Thread Mauro Carvalho Chehab
Em 19-05-2011 07:41, Sakari Ailus escreveu: > This patch adds the driver for the adp1653 LED flash controller. This > controller supports a high power led in flash and torch modes and an > indicator light, sometimes also called privacy light. > > The adp1653 is used on the Nokia N900. > > Signed-

[PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-19 Thread Sakari Ailus
This patch adds the driver for the adp1653 LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also called privacy light. The adp1653 is used on the Nokia N900. Signed-off-by: Sakari Ailus Signed-off-by: Tuukka Toivonen Sign

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-17 Thread Laurent Pinchart
Hi Sakari, On Tuesday 17 May 2011 12:47:25 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Tuesday 17 May 2011 07:38:38 Sakari Ailus wrote: > [clip] > > >>> If several applications read controls, only one of them will be > >>> notified of faults. Shouldn't clearing the fault be handled expli

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-17 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, Hi Laurent, > On Tuesday 17 May 2011 07:38:38 Sakari Ailus wrote: [clip] >>> >>> If several applications read controls, only one of them will be notified >>> of faults. Shouldn't clearing the fault be handled explicitly by writing >>> to a control ? I know thi

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-17 Thread Laurent Pinchart
Hi Sakari, On Tuesday 17 May 2011 07:38:38 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Monday 16 May 2011 15:00:39 Sakari Ailus wrote: > >> This patch adds the driver for the adp1653 LED flash controller. This > >> controller supports a high power led in flash and torch modes and an > >>

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-16 Thread Sakari Ailus
Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the patch. Thanks for the comments! :-) > On Monday 16 May 2011 15:00:39 Sakari Ailus wrote: >> This patch adds the driver for the adp1653 LED flash controller. This >> controller supports a high power led in flash and torch modes and an >> ind

Re: [PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-16 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Monday 16 May 2011 15:00:39 Sakari Ailus wrote: > This patch adds the driver for the adp1653 LED flash controller. This > controller supports a high power led in flash and torch modes and an > indicator light, sometimes also called privacy light. > > The adp16

[PATCH 3/3] adp1653: Add driver for LED flash controller

2011-05-16 Thread Sakari Ailus
This patch adds the driver for the adp1653 LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also called privacy light. The adp1653 is used on the Nokia N900. Signed-off-by: Sakari Ailus Signed-off-by: Tuukka Toivonen Sign