Re: [PATCH 3/3] media: add Rockchip VPU driver

2018-08-02 Thread Ezequiel Garcia
On Thu, 2018-08-02 at 09:30 +0200, Hans Verkuil wrote: > On 07/27/2018 07:13 PM, Ezequiel Garcia wrote: > > Hi Hans, > > > > Thanks a lot for the review. > > > > On Wed, 2018-07-18 at 11:58 +0200, Hans Verkuil wrote: > > > > > > > > + > > > > +static int > > > > +queue_init(void *priv, struct vb

Re: [PATCH 3/3] media: add Rockchip VPU driver

2018-08-02 Thread Ezequiel Garcia
On 2 August 2018 at 05:54, Hans Verkuil wrote: > On 08/01/18 23:07, Ezequiel Garcia wrote: >> Add a mem2mem driver for the VPU available on Rockchip SoCs. >> Currently only JPEG encoding is supported, for RK3399 and RK3288 >> platforms. >> >> Signed-off-by: Ezequiel Garcia [..] > > I stop reviewi

Re: [PATCH 3/3] media: add Rockchip VPU driver

2018-08-02 Thread Hans Verkuil
On 08/01/18 23:07, Ezequiel Garcia wrote: > Add a mem2mem driver for the VPU available on Rockchip SoCs. > Currently only JPEG encoding is supported, for RK3399 and RK3288 > platforms. > > Signed-off-by: Ezequiel Garcia > --- > drivers/media/platform/Kconfig| 12 + > drivers/med

Re: [PATCH 3/3] media: add Rockchip VPU driver

2018-08-02 Thread Hans Verkuil
On 07/27/2018 07:13 PM, Ezequiel Garcia wrote: > Hi Hans, > > Thanks a lot for the review. > > On Wed, 2018-07-18 at 11:58 +0200, Hans Verkuil wrote: >>> >>> + >>> +static int >>> +queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq) >>> +{ >>> + struct rockchip_vpu_ctx *c

[PATCH 3/3] media: add Rockchip VPU driver

2018-08-01 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/Kconfig| 12 + drivers/media/platform/Makefile | 1 + drivers/media/

Re: [PATCH 3/3] media: add Rockchip VPU driver

2018-07-27 Thread Ezequiel Garcia
Hi Hans, Thanks a lot for the review. On Wed, 2018-07-18 at 11:58 +0200, Hans Verkuil wrote: > > > > + > > +static int > > +queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq) > > +{ > > + struct rockchip_vpu_ctx *ctx = priv; > > + int ret; > > + > > + src_vq->type =

Re: [PATCH 3/3] media: add Rockchip VPU driver

2018-07-18 Thread Hans Verkuil
On 05/07/18 19:28, Ezequiel Garcia wrote: > Add a mem2mem driver for the VPU available on Rockchip SoCs. > Currently only JPEG encoding is supported, for RK3399 and RK3288 > platforms. > > Signed-off-by: Ezequiel Garcia > --- > drivers/media/platform/Kconfig| 12 + > drivers/med

[PATCH 3/3] media: add Rockchip VPU driver

2018-07-05 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/Kconfig| 12 + drivers/media/platform/Makefile | 1 + drivers/media/