Re: [PATCH 3/4] tsi108_eth: use dma API properly

2018-01-18 Thread David Miller
From: Bjorn Helgaas Date: Wed, 17 Jan 2018 18:08:18 -0600 > [+cc David, FYI, I plan to merge this via PCI along with the rest of > Christoph's series] No problem.

Re: [PATCH 3/4] tsi108_eth: use dma API properly

2018-01-17 Thread Bjorn Helgaas
[+cc David, FYI, I plan to merge this via PCI along with the rest of Christoph's series] On Wed, Jan 10, 2018 at 07:03:21PM +0100, Christoph Hellwig wrote: > We need to pass a struct device to the dma API, even if some > architectures still support that for legacy reasons, and should not mix > it

Re: [PATCH 3/4] tsi108_eth: use dma API properly

2018-01-15 Thread Christoph Hellwig
On Wed, Jan 10, 2018 at 10:09:20PM +0200, Andy Shevchenko wrote: > > + struct platform_device *pdev; > > Do you really need platform_defice reference? > > Perhaps > > struct device *hdev; // hardware device > > > data->hdev = >dev; > > Another idea > > dev->dev.parent = >dev; > > No

Re: [PATCH 3/4] tsi108_eth: use dma API properly

2018-01-10 Thread Andy Shevchenko
On Wed, Jan 10, 2018 at 8:03 PM, Christoph Hellwig wrote: > We need to pass a struct device to the dma API, even if some > architectures still support that for legacy reasons, and should not mix > it with the old PCI dma API. > > Note that the driver also seems to never actually

[PATCH 3/4] tsi108_eth: use dma API properly

2018-01-10 Thread Christoph Hellwig
We need to pass a struct device to the dma API, even if some architectures still support that for legacy reasons, and should not mix it with the old PCI dma API. Note that the driver also seems to never actually unmap its dma mappings, but to fix that we'll need someone more familar with the