Re: [PATCH 3/5] media: ov5640: fix wrong binning value in exposure calculation

2018-07-04 Thread jacopo mondi
Hi Hugues, On Wed, Jul 04, 2018 at 03:29:56PM +, Hugues FRUCHET wrote: > Hi Jacopo, > > Many thanks for you valuable comments, I hardly understand this exposure > code, and still some wrongly exposed images are observed switching from > subsampling to scaling modes. Thank you for the

Re: [PATCH 3/5] media: ov5640: fix wrong binning value in exposure calculation

2018-07-04 Thread Hugues FRUCHET
Hi Jacopo, Many thanks for you valuable comments, I hardly understand this exposure code, and still some wrongly exposed images are observed switching from subsampling to scaling modes. Steve, do you have more insight to share with us on this code ? On 07/04/2018 04:38 PM, jacopo mondi wrote:

Re: [PATCH 3/5] media: ov5640: fix wrong binning value in exposure calculation

2018-07-04 Thread jacopo mondi
Hi Hugues, On Wed, Jul 04, 2018 at 02:58:41PM +0200, Hugues Fruchet wrote: > ov5640_set_mode_exposure_calc() is checking binning value but > binning value read is buggy and binning value set is done > after calling ov5640_set_mode_exposure_calc(), fix all of this. The ov5640_binning_on()

[PATCH 3/5] media: ov5640: fix wrong binning value in exposure calculation

2018-07-04 Thread Hugues Fruchet
ov5640_set_mode_exposure_calc() is checking binning value but binning value read is buggy and binning value set is done after calling ov5640_set_mode_exposure_calc(), fix all of this. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 4 ++-- 1 file changed, 2 insertions(+), 2