Re: [PATCH 3/8] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-07-01 Thread Sakari Ailus
Hi Sylwester, On Sat, Jun 30, 2012 at 10:22:30PM +0200, Sylwester Nawrocki wrote: On 06/30/2012 07:03 PM, Sakari Ailus wrote: Would be good to add at least a small description here, that this patch converts users of V4L2_SUBDEV_SEL_TGT_* to use V4L2_SEL_TGT_*, or something similar. Fixed.

Re: [PATCH 3/8] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-07-01 Thread Sylwester Nawrocki
On 07/01/2012 01:13 PM, Sakari Ailus wrote: Correct. There's been so many variations of these that I've become blind to small differences. ;-) I could imagine ;) That's where peer reviews are helpful. I really like how it looks now though, you've done pretty good job. Thanks, Sylwester -- To

[PATCH 3/8] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-06-30 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/omap3isp/ispccdc.c |6 +- drivers/media/video/omap3isp/isppreview.c |6 +- drivers/media/video/omap3isp/ispresizer.c |6 +-

Re: [PATCH 3/8] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-06-30 Thread Sylwester Nawrocki
Hi Sakari, On 06/30/2012 07:03 PM, Sakari Ailus wrote: Would be good to add at least a small description here, that this patch converts users of V4L2_SUBDEV_SEL_TGT_* to use V4L2_SEL_TGT_*, or something similar. Signed-off-by: Sakari Ailussakari.ai...@iki.fi Signed-off-by: Sylwester