Re: [PATCH 4/4] mn88472: implemented ber reporting

2014-12-14 Thread Antti Palosaari
On 12/13/2014 01:12 PM, Benjamin Larsson wrote: On 12/13/2014 05:15 AM, Antti Palosaari wrote: On 12/13/2014 02:18 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson benja...@southpole.se Reviewed-by: Antti Palosaari cr...@iki.fi Even I could accept that, as a staging driver, I

Re: [PATCH 4/4] mn88472: implemented ber reporting

2014-12-13 Thread Benjamin Larsson
On 12/13/2014 05:15 AM, Antti Palosaari wrote: On 12/13/2014 02:18 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson benja...@southpole.se Reviewed-by: Antti Palosaari cr...@iki.fi Even I could accept that, as a staging driver, I see there some issues: * missing commit message

Re: [PATCH 4/4] mn88472: implemented ber reporting

2014-12-12 Thread Antti Palosaari
On 12/13/2014 02:18 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson benja...@southpole.se Reviewed-by: Antti Palosaari cr...@iki.fi Even I could accept that, as a staging driver, I see there some issues: * missing commit message (ok, it is trivial and patch subject says) * it