RE: [PATCH 5/5 v2] [media] ov9740: Add suspend/resume

2011-06-01 Thread Guennadi Liakhovetski
On Tue, 31 May 2011, Andrew Chew wrote: + /* For suspend/resume. */ + struct v4l2_mbus_framefmt current_mf; + int current_enable; bool? Are you sure you want this to be a bool? This thing is trying to shadow the enable parameter of the

RE: [PATCH 5/5 v2] [media] ov9740: Add suspend/resume

2011-05-31 Thread Andrew Chew
+ /* For suspend/resume. */ + struct v4l2_mbus_framefmt current_mf; + int current_enable; bool? Are you sure you want this to be a bool? This thing is trying to shadow the enable parameter of the s_stream() callback, and that enable parameter is

Re: [PATCH 5/5 v2] [media] ov9740: Add suspend/resume

2011-05-29 Thread Guennadi Liakhovetski
On Wed, 25 May 2011, ac...@nvidia.com wrote: From: Andrew Chew ac...@nvidia.com On suspend, remember whether we are streaming or not, and at what frame format, so that on resume, we can start streaming again. Signed-off-by: Andrew Chew ac...@nvidia.com ---

[PATCH 5/5 v2] [media] ov9740: Add suspend/resume

2011-05-25 Thread achew
From: Andrew Chew ac...@nvidia.com On suspend, remember whether we are streaming or not, and at what frame format, so that on resume, we can start streaming again. Signed-off-by: Andrew Chew ac...@nvidia.com --- drivers/media/video/ov9740.c | 39 +++ 1