Re: [PATCH 6/7] ARM: at91: dts: sama5d3: add ov2640 camera sensor support

2014-12-22 Thread Alexandre Belloni
Hi Josh, On 22/12/2014 at 15:06:07 +0800, Josh Wu wrote : I've acked your previous patch but maybe it should be named pinctrl_isi_pck1_as_mck to be clearer (you used the handle to pck1 below). It's a good idea. Maybe I prefer to use the name: pinctrl_pck1_as_isi_mck ? If you are ok with this

Re: [PATCH 6/7] ARM: at91: dts: sama5d3: add ov2640 camera sensor support

2014-12-21 Thread Josh Wu
Hi, Alexandre Thanks for the review. On 12/20/2014 5:05 AM, Alexandre Belloni wrote: On 18/12/2014 at 16:51:06 +0800, Josh Wu wrote : According to v4l2 dt document, we add: a camera host: ISI port. a i2c camera sensor: ov2640 port. to sama5d3xmb.dtsi. In the ov2640 node, it defines the

Re: [PATCH 6/7] ARM: at91: dts: sama5d3: add ov2640 camera sensor support

2014-12-19 Thread Alexandre Belloni
On 18/12/2014 at 16:51:06 +0800, Josh Wu wrote : According to v4l2 dt document, we add: a camera host: ISI port. a i2c camera sensor: ov2640 port. to sama5d3xmb.dtsi. In the ov2640 node, it defines the pinctrls, clocks and isi port. In the ISI node, it also reference to a ov2640 port.

[PATCH 6/7] ARM: at91: dts: sama5d3: add ov2640 camera sensor support

2014-12-18 Thread Josh Wu
According to v4l2 dt document, we add: a camera host: ISI port. a i2c camera sensor: ov2640 port. to sama5d3xmb.dtsi. In the ov2640 node, it defines the pinctrls, clocks and isi port. In the ISI node, it also reference to a ov2640 port. Signed-off-by: Josh Wu josh...@atmel.com ---

Re: [PATCH 6/7] ARM: at91: dts: sama5d3: add ov2640 camera sensor support

2014-12-18 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Thursday 18 December 2014 16:51:06 Josh Wu wrote: According to v4l2 dt document, we add: a camera host: ISI port. a i2c camera sensor: ov2640 port. to sama5d3xmb.dtsi. In the ov2640 node, it defines the pinctrls, clocks and isi port. In the ISI

Re: [PATCH 6/7] ARM: at91: dts: sama5d3: add ov2640 camera sensor support

2014-12-18 Thread Josh Wu
Hi, Laurent On 12/18/2014 8:32 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Thursday 18 December 2014 16:51:06 Josh Wu wrote: According to v4l2 dt document, we add: a camera host: ISI port. a i2c camera sensor: ov2640 port. to sama5d3xmb.dtsi. In the ov2640 node,