On 06/15/2017 03:34 PM, Sakari Ailus wrote:
> Hi Jacek,
>
> On Thu, Jun 15, 2017 at 03:01:47PM +0200, Jacek Anaszewski wrote:
>> Hi Sakari,
>>
>> On 06/15/2017 12:10 AM, Sakari Ailus wrote:
>>> Hi Jacek,
>>>
>>> Thanks for the review!
>>
>> You're welcome!
>>
>>> I have to say I found the
Hi Jacek,
On Thu, Jun 15, 2017 at 03:01:47PM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 06/15/2017 12:10 AM, Sakari Ailus wrote:
> > Hi Jacek,
> >
> > Thanks for the review!
>
> You're welcome!
>
> > I have to say I found the v4l2-flash-led-class framework quite useful, now
> > that I
Hi Sakari,
On 06/15/2017 12:10 AM, Sakari Ailus wrote:
> Hi Jacek,
>
> Thanks for the review!
You're welcome!
> I have to say I found the v4l2-flash-led-class framework quite useful, now
> that I refactored a driver for using it. Now we have a user for the
> indicator, too. :-)
Nice :-). I'm
Krasny den!
> > > Thanks for the review!
> >
> > You are welcome :-).
> >
> > > On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote:
> > > > Hi!
> > > >
> > > > > From: Sakari Ailus
> > > >
> > > > That address no longer works, right?
> > >
> > > Why wouldn't
Ahoy!
On Thu, Jun 15, 2017 at 12:28:33AM +0200, Pavel Machek wrote:
> Hi!
>
> > Thanks for the review!
>
> You are welcome :-).
>
> > On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > > From: Sakari Ailus
> > >
> > > That address no
Hi!
> Thanks for the review!
You are welcome :-).
> On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > From: Sakari Ailus
> >
> > That address no longer works, right?
>
> Why wouldn't it work? Or... do you know something I don't? :-)
Aha. I
Hi Pavel,
Thanks for the review!
On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote:
> Hi!
>
> > From: Sakari Ailus
>
> That address no longer works, right?
Why wouldn't it work? Or... do you know something I don't? :-)
>
> > Add a LED flash class driver for
Hi Jacek,
Thanks for the review!
I have to say I found the v4l2-flash-led-class framework quite useful, now
that I refactored a driver for using it. Now we have a user for the
indicator, too. :-)
On Wed, Jun 14, 2017 at 11:15:24PM +0200, Jacek Anaszewski wrote:
> > +static __maybe_unused int
Hi!
> From: Sakari Ailus
That address no longer works, right?
> Add a LED flash class driver for the as3654a flash controller. A V4L2 flash
> driver for it already exists (drivers/media/i2c/as3645a.c), and this driver
> is based on that.
>
> Signed-off-by: Sakari Ailus
Hi Sakari,
I have two remarks in the code below.
On 06/14/2017 11:47 AM, Sakari Ailus wrote:
> From: Sakari Ailus
>
> Add a LED flash class driver for the as3654a flash controller. A V4L2 flash
> driver for it already exists (drivers/media/i2c/as3645a.c), and this driver
>
From: Sakari Ailus
Add a LED flash class driver for the as3654a flash controller. A V4L2 flash
driver for it already exists (drivers/media/i2c/as3645a.c), and this driver
is based on that.
Signed-off-by: Sakari Ailus
---
MAINTAINERS
11 matches
Mail list logo