[PATCH RFC] omap3isp: prevent releasing MC too early

Avoid calling streamoff without having the media structs allocated. Signed-off-by: Mauro Carvalho Chehab --- Javier, Could you please test this patch? Thanks! Mauro drivers/media/platform/omap3isp/ispvideo.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drive

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hi Mauro, (CC'ing Greg) On Wednesday 14 Dec 2016 13:14:06 Mauro Carvalho Chehab wrote: > Avoid calling streamoff without having the media structs allocated. > > Signed-off-by: Mauro Carvalho Chehab The driver has a maintainer listed in MAINTAINERS, and you know that Sakari is also actively in

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

On Thu, Dec 15, 2016 at 02:13:42PM +0200, Laurent Pinchart wrote: > Hi Mauro, > > (CC'ing Greg) > > On Wednesday 14 Dec 2016 13:14:06 Mauro Carvalho Chehab wrote: > > Avoid calling streamoff without having the media structs allocated. > > > > Signed-off-by: Mauro Carvalho Chehab > > The driver

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Em Thu, 15 Dec 2016 14:13:42 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > (CC'ing Greg) > > On Wednesday 14 Dec 2016 13:14:06 Mauro Carvalho Chehab wrote: > > Avoid calling streamoff without having the media structs allocated. > > > > Signed-off-by: Mauro Carvalho Chehab > > The driver

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hello Mauro, On 12/15/2016 09:37 AM, Mauro Carvalho Chehab wrote: [snip] > > What happens is that omap3isp driver calls media_device_unregister() > too early. Right now, it is called at omap3isp_video_device_release(), > with happens when a driver unbind is ordered by userspace, and not after >

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Em Thu, 15 Dec 2016 09:42:35 -0300 Javier Martinez Canillas escreveu: > Hello Mauro, > > On 12/15/2016 09:37 AM, Mauro Carvalho Chehab wrote: > > [snip] > > > > > What happens is that omap3isp driver calls media_device_unregister() > > too early. Right now, it is called at omap3isp_video_devi

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hi Mauro, On Thursday 15 Dec 2016 10:37:34 Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 14:13:42 +0200 Laurent Pinchart escreveu: > > On Wednesday 14 Dec 2016 13:14:06 Mauro Carvalho Chehab wrote: > >> Avoid calling streamoff without having the media structs allocated. > >> > >> Signed-off-

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

On Thu, Dec 15, 2016 at 10:57:16AM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 09:42:35 -0300 > Javier Martinez Canillas escreveu: > > > Hello Mauro, > > > > On 12/15/2016 09:37 AM, Mauro Carvalho Chehab wrote: > > > > [snip] > > > > > > > > What happens is that omap3isp driver

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hi Mauro, On Thursday 15 Dec 2016 10:57:16 Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 09:42:35 -0300 Javier Martinez Canillas escreveu: > > On 12/15/2016 09:37 AM, Mauro Carvalho Chehab wrote: > > > > [snip] > > > >> What happens is that omap3isp driver calls media_device_unregister() >

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Greg, Em Thu, 15 Dec 2016 05:44:38 -0800 Greg KH escreveu: > On Thu, Dec 15, 2016 at 10:57:16AM -0200, Mauro Carvalho Chehab wrote: > > Em Thu, 15 Dec 2016 09:42:35 -0300 > > Javier Martinez Canillas escreveu: > > > > > Hello Mauro, > > > > > > On 12/15/2016 09:37 AM, Mauro Carvalho Chehab

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hi Greg, On Thursday 15 Dec 2016 04:31:12 Greg KH wrote: > On Thu, Dec 15, 2016 at 02:13:42PM +0200, Laurent Pinchart wrote: > > Hi Mauro, > > > > (CC'ing Greg) > > > > On Wednesday 14 Dec 2016 13:14:06 Mauro Carvalho Chehab wrote: > > > Avoid calling streamoff without having the media structs a

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Em Thu, 15 Dec 2016 04:31:12 -0800 Greg KH escreveu: > On Thu, Dec 15, 2016 at 02:13:42PM +0200, Laurent Pinchart wrote: > > Hi Mauro, > > > > (CC'ing Greg) > > > > On Wednesday 14 Dec 2016 13:14:06 Mauro Carvalho Chehab wrote: > > > Avoid calling streamoff without having the media structs al

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hi Mauro and Greg, On Thu, Dec 15, 2016 at 12:17:58PM -0200, Mauro Carvalho Chehab wrote: > Greg, > > Em Thu, 15 Dec 2016 05:44:38 -0800 > Greg KH escreveu: > > > On Thu, Dec 15, 2016 at 10:57:16AM -0200, Mauro Carvalho Chehab wrote: > > > Em Thu, 15 Dec 2016 09:42:35 -0300 > > > Javier Martine

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Em Thu, 15 Dec 2016 16:04:51 +0200 Laurent Pinchart escreveu: We have now two threads discussing the same subject, which is bad, as we'll end repeating the same arguments on different threads... Let's use the "[PATCH RFC 00/21]" for those discussions, as it seems we're reaching to somewhere the

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hi folks, On Fri, Dec 16, 2016 at 10:21:25AM +0200, Sakari Ailus wrote: ... > At least some of the issues the patches claim to fix are really not fixed > either. They are just made slightly less likely to accidentally stumble > upon. I couldn't immediately trigger this with the current mainline k

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

Hi Mauro, On Friday 16 Dec 2016 09:18:50 Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 16:04:51 +0200 Laurent Pinchart escreveu: > > We have now two threads discussing the same subject, which is bad, as > we'll end repeating the same arguments on different threads... > > Let's use the "[PAT