[PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

2011-11-19 Thread Ezequiel
Pushed video_device initialization into a separate function. Replace static allocation of struct video_device by video_device_alloc/video_device_release usage. Signed-off-by: Ezequiel Garcia --- Previous version was sent stupidly incomplete by mistake. --- diff --git a/drivers/media/video/gspca

Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

2011-11-19 Thread Antonio Ospite
On Sat, 19 Nov 2011 18:46:21 -0300 Ezequiel wrote: > Pushed video_device initialization into a separate function. > Replace static allocation of struct video_device by > video_device_alloc/video_device_release usage. > > Signed-off-by: Ezequiel Garcia > --- Hi Ezequiel, just a general commen

Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

2011-11-20 Thread Hans de Goede
Hi, On 11/19/2011 10:46 PM, Ezequiel wrote: Pushed video_device initialization into a separate function. Replace static allocation of struct video_device by video_device_alloc/video_device_release usage. NACK again! There is no reason to do this, it just makes the code more complicated withou

Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

2011-11-21 Thread Ezequiel
On Sun, Nov 20, 2011 at 11:03:21AM +0100, Hans de Goede wrote: > NACK again! There is no reason to do this, it just makes > the code more complicated without gaining anything. As already > commented by Antonio Ospite your commit message lacks the why of > this patch / the reason to do such a patch.