Re: [PATCH v2] [media] mantis: fix error handling

2015-03-22 Thread Dan Carpenter
Good, but still a couple nits. On Sun, Mar 22, 2015 at 06:16:18PM +0100, Silvan Jegen wrote: > --- a/drivers/media/pci/mantis/mantis_cards.c > +++ b/drivers/media/pci/mantis/mantis_cards.c > @@ -170,7 +170,7 @@ static int mantis_pci_probe(struct pci_dev *pdev, > if (mantis == NULL) { >

Re: [PATCH v2] [media] mantis: fix error handling

2015-03-22 Thread walter harms
Am 22.03.2015 18:16, schrieb Silvan Jegen: > Remove dead code, make goto label names more expressive and add a label > in order to call mantis_dvb_exit if mantis_uart_init fails. > > Also make sure that mantis_pci_exit is called if we fail the > mantis_stream_control call and that we call mantis

[PATCH v2] [media] mantis: fix error handling

2015-03-22 Thread Silvan Jegen
Remove dead code, make goto label names more expressive and add a label in order to call mantis_dvb_exit if mantis_uart_init fails. Also make sure that mantis_pci_exit is called if we fail the mantis_stream_control call and that we call mantis_i2c_exit if mantis_get_mac fails. Signed-off-by: Silv