.@lists.infradead.org; ker...@pengutronix.de
>Subject: Re: [PATCH v2] [media] marvell-ccic: simplify and fix clk handling (a
>bit)
>
>On Thu, Sep 26, 2013 at 10:13:56AM +0200, Uwe Kleine-König wrote:
>> Hi Libin,
>>
>> On Wed, Sep 25, 2013 at 07:47:19PM -0700, L
Hi Uwe,
Thanks for your reviewing. Please see the comments below.
>On Wed, Sep 25, 2013 at 07:47:19PM -0700, Libin Yang wrote:
>> In the clk enable and prepare function, we will check the NULL
>> pointer. So it should be no problem.
>I'm not sure what you mean here and unfortunately your quoting
On Thu, Sep 26, 2013 at 10:13:56AM +0200, Uwe Kleine-König wrote:
> Hi Libin,
>
> On Wed, Sep 25, 2013 at 07:47:19PM -0700, Libin Yang wrote:
> > In the clk enable and prepare function, we will check the NULL
> > pointer. So it should be no problem.
> I'm not sure what you mean here and unfortunat
Hi Libin,
On Wed, Sep 25, 2013 at 07:47:19PM -0700, Libin Yang wrote:
> In the clk enable and prepare function, we will check the NULL
> pointer. So it should be no problem.
I'm not sure what you mean here and unfortunately your quoting style
makes your statement appear without context.
i
ia@vger.kernel.org; linux-arm-
>ker...@lists.infradead.org; Russell King; ker...@pengutronix.de; Libin Yang
>Subject: Re: [PATCH v2] [media] marvell-ccic: simplify and fix clk handling (a
>bit)
>
>On Tue, 24 Sep 2013 20:59:47 +0200
>Uwe Kleine-König wrote:
>
>> The ma
On Tue, 24 Sep 2013 20:59:47 +0200
Uwe Kleine-König wrote:
> The marvell-ccic does several things wrong or ineffectively in the clock
> handling and it's usage of the devm_* stuff
>
> - it assumes clk_get doesn't return NULL
> - it explicitly calls devm_clk_put instead just keeping the referen
The marvell-ccic does several things wrong or ineffectively in the clock
handling and it's usage of the devm_* stuff
- it assumes clk_get doesn't return NULL
- it explicitly calls devm_clk_put instead just keeping the reference
during it's lifetime and let the driver core call it
- it calls
