The driver was reporting an incorrect mode, when mode 2
is selected.

While testing it, noticed that neither mode 1 or guard
interval 1/32 is supported by this device. Document it,
and ensure that it will report _AUTO when it doesn't lock,
in order to not report a wrong detection to userspace.

Signed-off-by: Mauro Carvalho Chehab <m.che...@samsung.com>
---
 drivers/media/dvb-frontends/mb86a20s.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/media/dvb-frontends/mb86a20s.c 
b/drivers/media/dvb-frontends/mb86a20s.c
index 227a420f7069..b931179c70a4 100644
--- a/drivers/media/dvb-frontends/mb86a20s.c
+++ b/drivers/media/dvb-frontends/mb86a20s.c
@@ -711,11 +711,10 @@ static int mb86a20s_get_frontend(struct dvb_frontend *fe)
        rc = mb86a20s_readreg(state, 0x07);
        if (rc < 0)
                return rc;
+       c->transmission_mode = TRANSMISSION_MODE_AUTO;
        if ((rc & 0x60) == 0x20) {
-               switch (rc & 0x0c >> 2) {
-               case 0:
-                       c->transmission_mode = TRANSMISSION_MODE_2K;
-                       break;
+               /* Only modes 2 and 3 are supported */
+               switch ((rc >> 2) & 0x03) {
                case 1:
                        c->transmission_mode = TRANSMISSION_MODE_4K;
                        break;
@@ -724,7 +723,9 @@ static int mb86a20s_get_frontend(struct dvb_frontend *fe)
                        break;
                }
        }
+       c->guard_interval = GUARD_INTERVAL_AUTO;
        if (!(rc & 0x10)) {
+               /* Guard interval 1/32 is not supported */
                switch (rc & 0x3) {
                case 0:
                        c->guard_interval = GUARD_INTERVAL_1_4;
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to