Re: [PATCH v2] media: remove bdisp_dbg_declare() and hva_dbg_declare()

2018-12-12 Thread Frank Lee
On Thu, Dec 6, 2018 at 7:49 PM Fabien DESSENNE wrote: > > Hi, > > The patch itself is OK, but the commit talks about bdisp & hva while the > patch is also for fimc-is. > Could you please update the commit header & messages? > > BR > > Fabien This file has been split into two. Thanks, Yangtao > >

Re: [PATCH v2] media: remove bdisp_dbg_declare() and hva_dbg_declare()

2018-12-06 Thread Fabien DESSENNE
Hi, The patch itself is OK, but the commit talks about bdisp & hva while the patch is also for fimc-is. Could you please update the commit header & messages? BR Fabien On 02/12/2018 3:04 AM, Yangtao Li wrote: > We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define > bdisp_dbg_de

[PATCH v2] media: remove bdisp_dbg_declare() and hva_dbg_declare()

2018-12-01 Thread Yangtao Li
We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define bdisp_dbg_declare and hva_dbg_declare,so remove them.Also use DEFINE_SHOW_ATTRIBUTE to simplify some code. Signed-off-by: Yangtao Li --- Changes in v2: -delete fimc_is_debugfs_open --- drivers/media/platform/exynos4-is/fimc-is.