Re: [PATCH v2 00/18] OMAP4 ISS driver

2013-11-04 Thread Hans Verkuil
On 11/04/2013 10:41 AM, Hans Verkuil wrote: > Hi Laurent, > > For this whole patch series: > > Acked-by: Hans Verkuil And also for patches 19-22 :-) Thanks! Hans > > I strongly recommend that you add another patch adding the s_input function. > It's trivial to do and it will make v4

Re: [PATCH v2 00/18] OMAP4 ISS driver

2013-11-04 Thread Laurent Pinchart
Hi Mauro, On Monday 04 November 2013 01:06:25 Laurent Pinchart wrote: > Hello, > > This is the second version of the OMAP4 ISS driver patches for inclusion in > the mainline kernel. I've addressed most of the comments received on the > first version (some of them are still being discussed) in add

Re: [PATCH v2 00/18] OMAP4 ISS driver

2013-11-04 Thread Hans Verkuil
Hi Laurent, For this whole patch series: Acked-by: Hans Verkuil I strongly recommend that you add another patch adding the s_input function. It's trivial to do and it will make v4l2-compliance happy :-) Fixing the issue with iss_video_try_format() and a missing get_fmt op is nice-to-have, but

[PATCH v2 00/18] OMAP4 ISS driver

2013-11-03 Thread Laurent Pinchart
Hello, This is the second version of the OMAP4 ISS driver patches for inclusion in the mainline kernel. I've addressed most of the comments received on the first version (some of them are still being discussed) in additional patches, except for the file path updates in the documentation that have