Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-21 Thread Laurent Pinchart
Hi Hans, On Thursday 17 July 2014 23:04:09 Hans Verkuil wrote: Hi Laurent, Something that just caught my eye: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-21 Thread Hans Verkuil
On 07/21/2014 10:56 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 17 July 2014 23:04:09 Hans Verkuil wrote: Hi Laurent, Something that just caught my eye: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-18 Thread Laurent Pinchart
Hi Hans, On Friday 18 July 2014 07:10:48 Hans Verkuil wrote: On 07/17/2014 11:22 PM, Hans Verkuil wrote: And another thing that I found while implementing this in v4l2-ctl: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-18 Thread Hans Verkuil
On 07/18/2014 02:27 PM, Laurent Pinchart wrote: Hi Hans, On Friday 18 July 2014 07:10:48 Hans Verkuil wrote: On 07/17/2014 11:22 PM, Hans Verkuil wrote: And another thing that I found while implementing this in v4l2-ctl: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-17 Thread Hans Verkuil
Hi Laurent, Something that just caught my eye: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields either, and in the v4l2_format structure which has reserved fields

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-17 Thread Hans Verkuil
And another thing that I found while implementing this in v4l2-ctl: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields either, and in the v4l2_format structure which

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-17 Thread Hans Verkuil
On 07/17/2014 11:22 PM, Hans Verkuil wrote: And another thing that I found while implementing this in v4l2-ctl: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-06-29 Thread Laurent Pinchart
Hi Hans, Thank you for the review. On Friday 27 June 2014 14:36:40 Hans Verkuil wrote: Hi Laurent, Some comments below... On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-06-27 Thread Hans Verkuil
Hi Laurent, Some comments below... On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields either, and in the v4l2_format structure which has reserved fields that were not

[PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-06-23 Thread Laurent Pinchart
The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields either, and in the v4l2_format structure which has reserved fields that were not previously required to be zeroed out by applications. To allow extending