Re: [PATCH v2 03/26] media: led-class-flash: better handle NULL flash struct

2017-11-02 Thread Sakari Ailus
Hi Mauro, Somehow the To header in your message ends up being: To: unlisted-recipients: no To-header on input <; This doesn't end well when replying to the messages. On Wed, Nov 01, 2017 at 05:05:40PM -0400, Mauro Carvalho Chehab wrote: > The logic at V4L2 led core assumes that the flash

[PATCH v2 03/26] media: led-class-flash: better handle NULL flash struct

2017-11-01 Thread Mauro Carvalho Chehab
The logic at V4L2 led core assumes that the flash struct can be null. However, it doesn't check for null while trying to set, causing some smatch to warn: drivers/media/v4l2-core/v4l2-flash-led-class.c:210 v4l2_flash_s_ctrl() error: we previously assumed 'fled_cdev' could be null (see