Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-29 Thread Jacob Chen
Hi Hans, 2017-11-27 22:15 GMT+08:00 Jose Abreu : > ++ Joao, ++ Luis > > Hi Hans, > > We will take a look into this. Thanks for pointing this out! > > Best Regards, > Jose Miguel Abreu > > On 27-11-2017 12:01, Hans Verkuil wrote: >> I'm CC-ing Jose Abreu from Synopsys to

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-27 Thread Jose Abreu
++ Joao, ++ Luis Hi Hans, We will take a look into this. Thanks for pointing this out! Best Regards, Jose Miguel Abreu On 27-11-2017 12:01, Hans Verkuil wrote: > I'm CC-ing Jose Abreu from Synopsys to this. Jose, can you or a colleague take > a look at this as well? > > Jacob, I have some

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-27 Thread Hans Verkuil
I'm CC-ing Jose Abreu from Synopsys to this. Jose, can you or a colleague take a look at this as well? Jacob, I have some high-level questions first: 1) to what extend is this code rockchip-specific as opposed to be more synopsys-generic? 2) I don't quite see how this works when there are two

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-26 Thread kbuild test robot
Hi Jacob, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20171124] [cannot apply to rockchip/for-next v4.14] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-26 Thread kbuild test robot
Hi Jacob, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20171124] [cannot apply to rockchip/for-next v4.14] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

[PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-23 Thread Jacob Chen
From: Jacob Chen This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver. The phy driver is kind of independent compare to the other parts, but i'd like to keep it in rkisp1 driver, unless people want to generalize it Signed-off-by: Jacob Chen

[PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-23 Thread Jacob Chen
From: Jacob Chen This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver. The phy driver is kind of independent compare to the other parts, but i'd like to keep it in rkisp1 driver, unless people want to generalize it Signed-off-by: Jacob Chen