Re: [PATCH v2 05/26] media: s5c73m3-core: fix logic on a timeout condition

2017-11-02 Thread Andrzej Hajda
On 01.11.2017 22:05, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/i2c/s5c73m3/s5c73m3-core.c:268 s5c73m3_check_status() > error: uninitialized symbol 'status'. > > if s5c73m3_check_status() is called too late, time_is_after_jiffies(end) > will return 0, causing the

[PATCH v2 05/26] media: s5c73m3-core: fix logic on a timeout condition

2017-11-01 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/i2c/s5c73m3/s5c73m3-core.c:268 s5c73m3_check_status() error: uninitialized symbol 'status'. if s5c73m3_check_status() is called too late, time_is_after_jiffies(end) will return 0, causing the while to abort before reading status. The current code will