Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread David Härdeman
On 2014-10-26 20:33, Tomas Melin wrote: On Sat, Oct 25, 2014 at 12:03 PM, David Härdeman da...@hardeman.nu wrote: Wouldn't something like this be a simpler way of achieving the same result? (untested): The idea was to remove the empty change_protocol function that had been added in the

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread Tomas Melin
On Tue, Oct 28, 2014 at 10:42 AM, David Härdeman da...@hardeman.nu wrote: On 2014-10-26 20:33, Tomas Melin wrote: Please let me know your preferences on which you prefer, and, if needed, I'll make a new patch version. I'd prefer the above, minimal, approach. But it's Mauro who decides in

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-26 Thread Tomas Melin
On Sat, Oct 25, 2014 at 12:03 PM, David Härdeman da...@hardeman.nu wrote: Wouldn't something like this be a simpler way of achieving the same result? (untested): The idea was to remove the empty change_protocol function that had been added in the breaking commit. IMHO, it would be better to not

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-25 Thread David Härdeman
On Tue, Oct 21, 2014 at 09:30:17PM +0300, Tomas Melin wrote: IR reciever using nuvoton-cir and lirc required additional configuration steps after upgrade from kernel 3.16 to 3.17-rcX. Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b ([media] rc-core: simplify sysfs code).

[PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-21 Thread Tomas Melin
IR reciever using nuvoton-cir and lirc required additional configuration steps after upgrade from kernel 3.16 to 3.17-rcX. Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b ([media] rc-core: simplify sysfs code). The regression comes from adding empty function change_protocol