Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-25 Thread javier Martin
Please, do not remove anyone from the CC list. On 25 May 2011 05:45, Chris Rodley carlight...@yahoo.co.nz wrote: Hi, Have upgraded the driver to Javier's latest RFC driver. Still having problems viewing output. Setting up with: # media-ctl -r -l 'mt9p031 2-0048:0-OMAP3 ISP CCDC:0[1], OMAP3

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-24 Thread javier Martin
Hi, Laurent, Guennadi, thank you for your review. I've already fixed most of the issues. On 23 May 2011 11:03, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Guennadi and Javier, On Saturday 21 May 2011 17:29:18 Guennadi Liakhovetski wrote: On Fri, 20 May 2011, Javier Martin

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-24 Thread Laurent Pinchart
Hi Javier, On Tuesday 24 May 2011 10:31:46 javier Martin wrote: On 23 May 2011 11:03, Laurent Pinchart wrote: On Saturday 21 May 2011 17:29:18 Guennadi Liakhovetski wrote: On Fri, 20 May 2011, Javier Martin wrote: [snip] diff --git a/drivers/media/video/mt9p031.c

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-24 Thread Laurent Pinchart
Hi Javier, On Tuesday 24 May 2011 10:56:22 javier Martin wrote: On 24 May 2011 10:39, Laurent Pinchart wrote: On Tuesday 24 May 2011 10:31:46 javier Martin wrote: On 23 May 2011 11:03, Laurent Pinchart wrote: On Saturday 21 May 2011 17:29:18 Guennadi Liakhovetski wrote: On Fri, 20 May

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-24 Thread Chris Rodley
Hi, Have upgraded the driver to Javier's latest RFC driver. Still having problems viewing output. Setting up with: # media-ctl -r -l 'mt9p031 2-0048:0-OMAP3 ISP CCDC:0[1], OMAP3 ISP CCDC:1-OMAP3 ISP CCDC output:0[1]' Resetting all links to inactive Setting up link 16:0 - 5:0 [1] Setting up link

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread javier Martin
On 23 May 2011 05:01, Chris Rodley carlight...@yahoo.co.nz wrote: Error when using media-ctl as below with v2 mt9p031 driver from Javier and latest media-ctl version. Is there a patch I missed to add different formats - or maybe my command is wrong? # ./media-ctl -v -r -l 'mt9p031

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread javier Martin
On 21 May 2011 17:29, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 20 May 2011, Javier Martin wrote: This driver adds basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  drivers/media/video/Kconfig   |    8 +  

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread Guennadi Liakhovetski
On Mon, 23 May 2011, javier Martin wrote: On 21 May 2011 17:29, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 20 May 2011, Javier Martin wrote: This driver adds basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread Laurent Pinchart
Hi Guennadi and Javier, On Saturday 21 May 2011 17:29:18 Guennadi Liakhovetski wrote: On Fri, 20 May 2011, Javier Martin wrote: [snip] diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c new file mode 100644 index 000..e406b64 --- /dev/null +++

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread Laurent Pinchart
Hi Guennadi, On Monday 23 May 2011 10:48:36 Guennadi Liakhovetski wrote: On Mon, 23 May 2011, javier Martin wrote: On 21 May 2011 17:29, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 20 May 2011, Javier Martin wrote: This driver adds basic support for Aptina mt9p031 sensor.

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread Guennadi Liakhovetski
On Mon, 23 May 2011, Laurent Pinchart wrote: +{ + struct mt9p031 *mt9p031 = to_mt9p031(client); + int ret; + + /* Disable chip output, synchronous option update */ + ret = reg_write(client, MT9P031_RST, MT9P031_RST_ENABLE); + if (ret 0) + return -EIO; + ret =

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread Chris Rodley
On 23/05/11 18:54, javier Martin wrote: On 23 May 2011 05:01, Chris Rodley carlight...@yahoo.co.nz wrote: Error when using media-ctl as below with v2 mt9p031 driver from Javier and latest media-ctl version. Is there a patch I missed to add different formats - or maybe my command is wrong?

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-22 Thread Laurent Pinchart
Hi Mauro, On Saturday 21 May 2011 14:55:12 Mauro Carvalho Chehab wrote: Hi Laurent, Despite all those changes at Nokia side, I'm still assuming that you're handling the omap3 patches. That's correct. I maintain (with Sakari) the OMAP3 ISP driver. For practical reason I'm the one who sends

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-22 Thread Chris Rodley
Error when using media-ctl as below with v2 mt9p031 driver from Javier and latest media-ctl version. Is there a patch I missed to add different formats - or maybe my command is wrong? # ./media-ctl -v -r -l 'mt9p031 2-0048:0-OMAP3 ISP CCDC:0[1], OMAP3 ISP CCDC:1-OMAP3 ISP CCDC output:0[1]'

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-21 Thread Mauro Carvalho Chehab
Hi Laurent, Despite all those changes at Nokia side, I'm still assuming that you're handling the omap3 patches. So, I'm just marking those two patches as RFC until I receive a pull request from you. Anyway, in this specific case, Koen made some comments, so we should wait for Javier answer

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-21 Thread Guennadi Liakhovetski
On Fri, 20 May 2011, Javier Martin wrote: This driver adds basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 751

[PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-20 Thread Javier Martin
This driver adds basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 751 +