Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-07 Thread Malcolm Priestley
On 07/09/14 00:38, Antti Palosaari wrote: On 09/07/2014 01:37 AM, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 22:37:21 +0100 Malcolm Priestley tvbox...@gmail.com escreveu: On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Akihiro TSUKADA
Moikka!, thanks for the comments and advices. I had been updating my code and during that, I also found that updating property cache in tuner_ops.get_signal_strength() was simple and (seemed to me) better than using a kthread, so the current implementation (under testing) is just like what Mauro

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Antti Palosaari
On 09/06/2014 07:08 AM, Akihiro TSUKADA wrote: Moikka!, thanks for the comments and advices. I had been updating my code and during that, I also found that updating property cache in tuner_ops.get_signal_strength() was simple and (seemed to me) better than using a kthread, so the current

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Mauro Carvalho Chehab
Em Sat, 06 Sep 2014 06:34:33 +0300 Antti Palosaari cr...@iki.fi escreveu: On 09/06/2014 06:17 AM, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 06:10:01 +0300 Antti Palosaari cr...@iki.fi escreveu: ... I simply don't understand why you want hook that RF strength call via demod? The

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Mauro Carvalho Chehab
Em Sat, 06 Sep 2014 13:36:14 +0300 Antti Palosaari cr...@iki.fi escreveu: On 09/06/2014 07:08 AM, Akihiro TSUKADA wrote: Moikka!, thanks for the comments and advices. I had been updating my code and during that, I also found that updating property cache in

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Malcolm Priestley
On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which reads RSSI and writes value to struct

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Malcolm Priestley
On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Malcolm Priestley
On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Mauro Carvalho Chehab
Em Sat, 06 Sep 2014 22:37:21 +0100 Malcolm Priestley tvbox...@gmail.com escreveu: On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi escreveu: Moro! On 08/29/2014 01:45 PM,

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Antti Palosaari
On 09/07/2014 01:37 AM, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 22:37:21 +0100 Malcolm Priestley tvbox...@gmail.com escreveu: On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-05 Thread Antti Palosaari
Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which reads RSSI and writes value to struct dtv_frontend_properties. That it is, in my understanding. Same for all those DVBv5 stats. Mauro knows better as he designed that

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-05 Thread Mauro Carvalho Chehab
Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which reads RSSI and writes value to struct dtv_frontend_properties. That it is, in my

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Sep 2014 23:51:05 -0300 Mauro Carvalho Chehab m.che...@samsung.com escreveu: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so,

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-05 Thread Antti Palosaari
On 09/06/2014 05:54 AM, Mauro Carvalho Chehab wrote: Em Fri, 5 Sep 2014 23:51:05 -0300 Mauro Carvalho Chehab m.che...@samsung.com escreveu: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-05 Thread Mauro Carvalho Chehab
Em Sat, 06 Sep 2014 06:10:01 +0300 Antti Palosaari cr...@iki.fi escreveu: On 09/06/2014 05:54 AM, Mauro Carvalho Chehab wrote: Em Fri, 5 Sep 2014 23:51:05 -0300 Mauro Carvalho Chehab m.che...@samsung.com escreveu: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari cr...@iki.fi

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-05 Thread Antti Palosaari
On 09/06/2014 06:17 AM, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 06:10:01 +0300 Antti Palosaari cr...@iki.fi escreveu: ... I simply don't understand why you want hook that RF strength call via demod? The frontend cache is shared between demod and tuner. We use it for tuner driver as

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-08-29 Thread Akihiro TSUKADA
moikka, Start polling thread, which polls once per 2 sec or so, which reads RSSI and writes value to struct dtv_frontend_properties. That it is, in my understanding. Same for all those DVBv5 stats. Mauro knows better as he designed that functionality. I understand that RSSI property should

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-08-28 Thread Akihiro TSUKADA
moikka, thanks for the comment. I have feeling DVBv5 API is aimed to transfer data via property cached. I haven't done much driver for DVBv5 statistics, but recently I implemented CNR (DVBv5 stats) to Si2168 driver and it just writes all the values directly to property cache. I expect RF

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-08-28 Thread Antti Palosaari
moikka! On 08/28/2014 12:07 PM, Akihiro TSUKADA wrote: moikka, thanks for the comment. I have feeling DVBv5 API is aimed to transfer data via property cached. I haven't done much driver for DVBv5 statistics, but recently I implemented CNR (DVBv5 stats) to Si2168 driver and it just writes all

[PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-08-27 Thread tskd08
From: Akihiro Tsukada tsk...@gmail.com fe-ops.tuner_ops.get_rf_strength() reports its result in u16, while in DVB APIv5 it should be reported in s64 and by 0.001dBm. Signed-off-by: Akihiro Tsukada tsk...@gmail.com --- drivers/media/dvb-core/dvb_frontend.h | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-08-27 Thread Antti Palosaari
Moikka I have feeling DVBv5 API is aimed to transfer data via property cached. I haven't done much driver for DVBv5 statistics, but recently I implemented CNR (DVBv5 stats) to Si2168 driver and it just writes all the values directly to property cache. I expect RF strength (RSSI) is just