Re: [PATCH v2 1/6] media: add media token device resource framework

2014-11-18 Thread Sakari Ailus
Hi Shuah, A few comments below. On Tue, Oct 14, 2014 at 08:58:37AM -0600, Shuah Khan wrote: > Add media token device resource framework to allow sharing > resources such as tuner, dma, audio etc. across media drivers > and non-media sound drivers that control media hardware. The > Media token res

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-21 Thread Takashi Iwai
At Tue, 21 Oct 2014 13:58:59 +0200, Hans Verkuil wrote: > > > > On 10/21/2014 01:51 PM, Takashi Iwai wrote: > > At Tue, 21 Oct 2014 12:46:03 +0200, > > Hans Verkuil wrote: > >> > >> Hi Shuah, > >> > >> As promised, here is my review for this patch series. > >> > >> On 10/14/2014 04:58 PM, Shuah

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-21 Thread Hans Verkuil
On 10/21/2014 01:51 PM, Takashi Iwai wrote: At Tue, 21 Oct 2014 12:46:03 +0200, Hans Verkuil wrote: Hi Shuah, As promised, here is my review for this patch series. On 10/14/2014 04:58 PM, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner,

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-21 Thread Takashi Iwai
At Tue, 21 Oct 2014 12:46:03 +0200, Hans Verkuil wrote: > > Hi Shuah, > > As promised, here is my review for this patch series. > > On 10/14/2014 04:58 PM, Shuah Khan wrote: > > Add media token device resource framework to allow sharing > > resources such as tuner, dma, audio etc. across media d

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-21 Thread Hans Verkuil
Hi Shuah, As promised, here is my review for this patch series. On 10/14/2014 04:58 PM, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non-media sound drivers that control media hardware. The Media t

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-16 Thread Shuah Khan
On 10/16/2014 08:00 AM, Takashi Iwai wrote: > At Wed, 15 Oct 2014 18:53:28 -0600, > Shuah Khan wrote: >> >> On 10/15/2014 11:05 AM, Takashi Iwai wrote: >> +#if defined(CONFIG_MEDIA_SUPPORT) +extern int media_tknres_create(struct device *dev); +extern int media_tknres_destroy(struct d

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-16 Thread Takashi Iwai
At Wed, 15 Oct 2014 18:53:28 -0600, Shuah Khan wrote: > > On 10/15/2014 11:05 AM, Takashi Iwai wrote: > > >> +#if defined(CONFIG_MEDIA_SUPPORT) > >> +extern int media_tknres_create(struct device *dev); > >> +extern int media_tknres_destroy(struct device *dev); > >> + > >> +extern int media_get_tu

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-15 Thread Shuah Khan
On 10/15/2014 11:05 AM, Takashi Iwai wrote: >> +#if defined(CONFIG_MEDIA_SUPPORT) >> +extern int media_tknres_create(struct device *dev); >> +extern int media_tknres_destroy(struct device *dev); >> + >> +extern int media_get_tuner_tkn(struct device *dev); >> +extern int media_put_tuner_tkn(struct

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-15 Thread Takashi Iwai
At Tue, 14 Oct 2014 08:58:37 -0600, Shuah Khan wrote: > > Add media token device resource framework to allow sharing > resources such as tuner, dma, audio etc. across media drivers > and non-media sound drivers that control media hardware. The > Media token resource is created at the main struct d

[PATCH v2 1/6] media: add media token device resource framework

2014-10-14 Thread Shuah Khan
Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non-media sound drivers that control media hardware. The Media token resource is created at the main struct device that is common to all drivers that claim various pieces of