Re: [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread Igor Grinberg
On 05/23/11 10:47, Laurent Pinchart wrote: > Hi Javier, > > On Monday 23 May 2011 09:25:01 javier Martin wrote: >> On 22 May 2011 15:49, Igor Grinberg wrote: > [snip] > @@ -309,6 +357,15 @@ static int beagle_twl_gpio_setup(struct device *dev, pr_err("%s: unable to configure EHCI_nOC\n",

Re: [beagleboard] [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread Laurent Pinchart
Hi Koen, On Monday 23 May 2011 10:55:53 Koen Kooi wrote: > Op 23 mei 2011, om 10:00 heeft Laurent Pinchart het volgende geschreven: > > On Monday 23 May 2011 09:01:07 javier Martin wrote: > >> On 20 May 2011 17:57, Koen Kooi wrote: > >>> In previous patch sets we put that in a seperate file > >>>

Re: [beagleboard] [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread Koen Kooi
Op 23 mei 2011, om 10:00 heeft Laurent Pinchart het volgende geschreven: > Hi Javier, > > On Monday 23 May 2011 09:01:07 javier Martin wrote: >> On 20 May 2011 17:57, Koen Kooi wrote: >>> In previous patch sets we put that in a seperate file >>> (omap3beagle-camera.c) so we don't clutter up the

Re: [beagleboard] [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread Laurent Pinchart
Hi Javier, On Monday 23 May 2011 09:01:07 javier Martin wrote: > On 20 May 2011 17:57, Koen Kooi wrote: > > In previous patch sets we put that in a seperate file > > (omap3beagle-camera.c) so we don't clutter up the board file with all > > the different sensor drivers. Would it make sense to do t

Re: [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread Laurent Pinchart
Hi Javier, On Monday 23 May 2011 09:25:01 javier Martin wrote: > On 22 May 2011 15:49, Igor Grinberg wrote: [snip] > >> @@ -309,6 +357,15 @@ static int beagle_twl_gpio_setup(struct device > >> *dev, pr_err("%s: unable to configure EHCI_nOC\n", __func__); } > >> > >> + if (omap3_beagle_get_

Re: [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread javier Martin
On 22 May 2011 15:49, Igor Grinberg wrote: > Hi Javier, > > > linux-omap should be CC'ed - added. > > In addition to Koen's comments, some comments below. > > > On 05/20/11 16:47, Javier Martin wrote: > >> isp.h file has to be included as a temporal measure >> since clocks of the isp are not expos

Re: [beagleboard] [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread javier Martin
On 20 May 2011 17:57, Koen Kooi wrote: > In previous patch sets we put that in a seperate file (omap3beagle-camera.c) > so we don't clutter up the board file with all the different sensor drivers. > Would it make sense to do the same with the current patches? It looks like > MCF cuts down a lot

Re: [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-22 Thread Igor Grinberg
Hi Javier, linux-omap should be CC'ed - added. In addition to Koen's comments, some comments below. On 05/20/11 16:47, Javier Martin wrote: > isp.h file has to be included as a temporal measure > since clocks of the isp are not exposed yet. > > Signed-off-by: Javier Martin > --- > arch/arm/

Re: [beagleboard] [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-20 Thread Koen Kooi
Op 20 mei 2011, om 15:47 heeft Javier Martin het volgende geschreven: > isp.h file has to be included as a temporal measure > since clocks of the isp are not exposed yet. > > Signed-off-by: Javier Martin > --- > arch/arm/mach-omap2/board-omap3beagle.c | 127 ++- Javi

[PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-20 Thread Javier Martin
isp.h file has to be included as a temporal measure since clocks of the isp are not exposed yet. Signed-off-by: Javier Martin --- arch/arm/mach-omap2/board-omap3beagle.c | 127 ++- 1 files changed, 123 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/b