Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-20 Thread Sangwook Lee
Hi Sylwester Thank you for the great review! On 19 July 2012 22:40, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Sangwook, A few review comments for you below... On 07/19/2012 02:14 PM, Sangwook Lee wrote: This dirver implements preview mode of the S5K4ECGX sensor. dirver

[PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-19 Thread Sangwook Lee
This dirver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/birghtness/sharpness Signed-off-by: Sangwook Lee sangwook@linaro.org --- drivers/media/video/Kconfig|7 +

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-19 Thread Sylwester Nawrocki
Hi Sangwook, A few review comments for you below... On 07/19/2012 02:14 PM, Sangwook Lee wrote: This dirver implements preview mode of the S5K4ECGX sensor. dirver - driver capture (snapshot) operation, face detection are missing now. Following controls are supported: