Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
On 03/18/15 16:44, Sakari Ailus wrote: I don't think omap3isp has been using this very long. A few minor versions perhaps. Do you know if this common code is supposed to guarantee a physically contiguous memory region? The documentation for the function doesn't indicate that it should, and it

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Sakari Ailus
Hi Tim, On Wed, Mar 18, 2015 at 03:58:07PM -0500, Tim Nordell wrote: > Laurent - > > On 03/18/15 14:49, Tim Nordell wrote: > >Digging through to find who is responsible for assigning the virtual > >addresses, I find that it's buried inside > >arch/arm/mm/dma-mapping.c:__alloc_iova(...). This cal

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 14:49, Tim Nordell wrote: Digging through to find who is responsible for assigning the virtual addresses, I find that it's buried inside arch/arm/mm/dma-mapping.c:__alloc_iova(...). This call is called individually for each entry in the scatter-gather table via __map_sg_ch

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 10:21, Laurent Pinchart wrote: Correct. sg_dma_address() should contain the DMA virtual address when an IOMMU is used. I was assuming it was checking the physical memory layout to it without looking too closely to the code. Armed with that knowledge, I'll dig a little dee

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Laurent Pinchart
Hi Tim, On Wednesday 18 March 2015 10:19:15 Tim Nordell wrote: > Laurent - > > On 03/18/15 09:59, Laurent Pinchart wrote: > > Hi Tim, > > The names might be a bit misleading, vb2-dma-contig requires contiguous > > memory in the device memory space, not in physical memory. The IOMMU, > > managed t

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 09:59, Laurent Pinchart wrote: Hi Tim, The names might be a bit misleading, vb2-dma-contig requires contiguous memory in the device memory space, not in physical memory. The IOMMU, managed through dma_map_sg_attrs, should have mapped the userptr buffer contiguously in the I

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Laurent Pinchart
Hi Tim, On Wednesday 18 March 2015 09:54:58 Tim Nordell wrote: > On 03/18/15 07:39, Laurent Pinchart wrote: > > On Tuesday 17 March 2015 17:57:30 Tim Nordell wrote: > >> On 04/21/14 07:29, Laurent Pinchart wrote: > >>> Replace the custom buffers queue implementation with a videobuf2 queue. > >>>

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 07:39, Laurent Pinchart wrote: Hi Tim, On Tuesday 17 March 2015 17:57:30 Tim Nordell wrote: On 04/21/14 07:29, Laurent Pinchart wrote: Replace the custom buffers queue implementation with a videobuf2 queue. Signed-off-by: Laurent Pinchart I realize this is late (it's

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Laurent Pinchart
Hi Tim, On Tuesday 17 March 2015 17:57:30 Tim Nordell wrote: > On 04/21/14 07:29, Laurent Pinchart wrote: > > Replace the custom buffers queue implementation with a videobuf2 queue. > > > > Signed-off-by: Laurent Pinchart > > I realize this is late (it's in the kernel now), but I'm noticing tha

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-17 Thread Tim Nordell
Hi - On 04/21/14 07:29, Laurent Pinchart wrote: Replace the custom buffers queue implementation with a videobuf2 queue. Signed-off-by: Laurent Pinchart I realize this is late (it's in the kernel now), but I'm noticing that this does not appear to properly support the scatter-gather buffers

[PATCH v2 25/26] omap3isp: Move to videobuf2

2014-04-21 Thread Laurent Pinchart
Replace the custom buffers queue implementation with a videobuf2 queue. Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap3isp/Makefile |2 +- drivers/media/platform/omap3isp/ispqueue.c | 1031 drivers/media/platform/omap3isp/ispqueue.h | 171