Hi,
okay for the moment. We can later think about optimizations, like "return 0"
functions.
I have no possibility of testing this functionality. But I guess it works with
your device, so
Acked-by: Tobias Lorenz
Bye,
Toby
On Sunday 19 July 2009 16:19:24 Alexey Klimov wrote:
> Hello,
>
> On T
>> +
>> +int si470x_disconnect_check(struct si470x_device *radio)
>> +{
>> + return 0;
>> +}
>
> Looks like this function is empty and it's called few times. Is it
> good to make it inline?
>
Yes, this function is empty. It looks fine to me too.
I will modify it, thanks.
--
To unsubscrib
Hello,
On Tue, Jul 14, 2009 at 9:15 AM, Joonyoung Shim wrote:
> This patch supports i2c interface of si470x. The i2c specific part
> exists in radio-si470x-i2c.c file and the common part uses
> radio-si470x-common.c file. The '#if defined' is inserted inevitably
> because of parts used only si470x
This patch supports i2c interface of si470x. The i2c specific part
exists in radio-si470x-i2c.c file and the common part uses
radio-si470x-common.c file. The '#if defined' is inserted inevitably
because of parts used only si470x usb in the common file.
The current driver version doesn't support th
