Re: [PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-24 Thread Josh Wu
Hi, Laurent On 8/22/2015 2:22 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Friday 21 August 2015 16:08:14 Josh Wu wrote: After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type.

Re: [PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-21 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Friday 21 August 2015 16:08:14 Josh Wu wrote: > After adding the format check in try_fmt()/set_fmt(), we don't need any > format check in configure_geometry(). So make configure_geometry() as > void type. > > Signed-off-by: Josh Wu > --- > > Changes in v3:

[PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-21 Thread Josh Wu
After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu --- Changes in v3: - check the whether format is supported, if no then return a default format. - misc changes accordi