Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-24 Thread Stanimir Varbanov
Hi Nicolas, On 11/23/2016 10:24 PM, Nicolas Dufresne wrote: > Le lundi 21 novembre 2016 à 18:09 +0200, Stanimir Varbanov a écrit : Meanwhile I have found bigger obstacle - I cannot run multiple >> instances simultaneously. By m2m design it can execute only one job (m2m >> context)

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-23 Thread Nicolas Dufresne
Le lundi 21 novembre 2016 à 18:09 +0200, Stanimir Varbanov a écrit : > >> Meanwhile I have found bigger obstacle - I cannot run multiple > instances > >> simultaneously. By m2m design it can execute only one job (m2m > context) > >> at a time per m2m device. Can you confirm that my observation is

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-21 Thread Stanimir Varbanov
On 11/21/2016 05:33 PM, Hans Verkuil wrote: > On 21/11/16 16:29, Stanimir Varbanov wrote: >> Hi Hans, >> >> On 11/21/2016 05:04 PM, Hans Verkuil wrote: >>> On 18/11/16 10:11, Stanimir Varbanov wrote: Hi Hans, >>> + >>> +static int >>> +vdec_reqbufs(struct file *file, void

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-21 Thread Hans Verkuil
On 21/11/16 16:29, Stanimir Varbanov wrote: Hi Hans, On 11/21/2016 05:04 PM, Hans Verkuil wrote: On 18/11/16 10:11, Stanimir Varbanov wrote: Hi Hans, + +static int +vdec_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *b) +{ +struct vb2_queue *queue = to_vb2q(file,

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-21 Thread Stanimir Varbanov
Hi Hans, On 11/21/2016 05:04 PM, Hans Verkuil wrote: > On 18/11/16 10:11, Stanimir Varbanov wrote: >> Hi Hans, >> > + > +static int > +vdec_reqbufs(struct file *file, void *fh, struct > v4l2_requestbuffers *b) > +{ > +struct vb2_queue *queue = to_vb2q(file, b->type);

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-21 Thread Hans Verkuil
On 18/11/16 10:11, Stanimir Varbanov wrote: Hi Hans, + +static int +vdec_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *b) +{ + struct vb2_queue *queue = to_vb2q(file, b->type); + + if (!queue) + return -EINVAL; + + return vb2_reqbufs(queue,

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-18 Thread Stanimir Varbanov
Hi Hans, >>> + >>> +static int >>> +vdec_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *b) >>> +{ >>> + struct vb2_queue *queue = to_vb2q(file, b->type); >>> + >>> + if (!queue) >>> + return -EINVAL; >>> + >>> + return vb2_reqbufs(queue, b); >>> +} >> >> Is there

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-14 Thread Stanimir Varbanov
Hi Hans, Thanks for the comments! On 11/11/2016 01:39 PM, Hans Verkuil wrote: > I made some comments about start_streaming in my review of patch 3/9, so > I am not going to repeat that here. Sure. > > On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: >> This consists of video decoder

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-11 Thread Hans Verkuil
I made some comments about start_streaming in my review of patch 3/9, so I am not going to repeat that here. On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: > This consists of video decoder implementation plus decoder > controls. > > Signed-off-by: Stanimir Varbanov

[PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-07 Thread Stanimir Varbanov
This consists of video decoder implementation plus decoder controls. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 1108 drivers/media/platform/qcom/venus/vdec.h | 32 +