Re: [PATCH v3 5/6] si2168: add I2C error handling

2015-05-07 Thread Olli Salonen
Hi Antti, I basically used the same code that was used earlier in the same function in case i2c_master_send/recv returns an unexpected result. When working with the RTL2832P based Si2168 device I noticed that at some point, often but not always during firmware loading, the Si2168 started to retur

Re: [PATCH v3 5/6] si2168: add I2C error handling

2015-05-07 Thread Antti Palosaari
Moikka! I didn't make any tests, but I could guess that error flag is set by firmware when some unsupported / invalid parameter is given as a firmware command request. Anyhow, I am not sure which is proper error code to return. Could you please study, check from API docs and so, which are sui

[PATCH v3 5/6] si2168: add I2C error handling

2015-05-03 Thread Olli Salonen
Return error from si2168_cmd_execute in case the demodulator returns an error. Signed-off-by: Olli Salonen --- drivers/media/dvb-frontends/si2168.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 29a5936