RE: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-23 Thread myungjoo.ham
2013/4/22 Inki Dae > 2013/4/22 Rafael J. Wysocki > > On Monday, April 22, 2013 12:37:36 PM Tomasz Figa wrote: > > > On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: > > > > On 04/22/2013 12:03 PM, Inki Dae wrote: > > > > > > Also looks good to me. But what if power domain was disa

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:05:49 Sylwester Nawrocki wrote: > On 04/22/2013 11:56 AM, Tomasz Figa wrote: > > On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > >> On 21 April 2013 20:13, Tomasz Figa wrote: > >>> 3) after those two changes, all that remains is to fix compliance with > >>>

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Rafael J. Wysocki
On Monday, April 22, 2013 12:37:36 PM Tomasz Figa wrote: > On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: > > On 04/22/2013 12:03 PM, Inki Dae wrote: > > > > Also looks good to me. But what if power domain was disabled without > > > > pm > > > > runtime? In this case, you

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: > On 04/22/2013 12:03 PM, Inki Dae wrote: > > > Also looks good to me. But what if power domain was disabled without > > > pm > > > runtime? In this case, you must enable the power domain at machine > > > code or > >

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Viresh Kumar
On 22 April 2013 15:26, Tomasz Figa wrote: > Can you assure that in future SoCs, on which this driver will be used, this > assumption will still hold true or even that in current Exynos driver this > behavior won't be changed? Probably yes.. Registers for enabling/disabling these clocks should al

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Sylwester Nawrocki
On 04/22/2013 12:03 PM, Inki Dae wrote: > > Also looks good to me. But what if power domain was disabled without pm > > runtime? In this case, you must enable the power domain at machine code > or > > bootloader somewhere. This way would not only need some hard codes to > turn > >

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Sylwester Nawrocki
On 04/22/2013 11:56 AM, Tomasz Figa wrote: > On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: >> On 21 April 2013 20:13, Tomasz Figa wrote: >>> 3) after those two changes, all that remains is to fix compliance with >>> Common Clock Framework, in other words: >>> >>> s/clk_enable/clk_prepare

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: > On 21 April 2013 20:13, Tomasz Figa wrote: > > 3) after those two changes, all that remains is to fix compliance with > > Common Clock Framework, in other words: > > > > s/clk_enable/clk_prepare_enable/ > > > > and > > > > s/clk_disable/

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > > > 2013/4/21 Tomasz Figa > > > > > > > Hi, > > > > > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > > > On 8 April 2013 16:37, Vikas Sajjan wrote: > > > > > > While migrating to common clock framework (CCF), I found that

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Viresh Kumar
On 21 April 2013 20:13, Tomasz Figa wrote: > 3) after those two changes, all that remains is to fix compliance with > Common Clock Framework, in other words: > > s/clk_enable/clk_prepare_enable/ > > and > > s/clk_disable/clk_disable_unprepare/ We don't have to call clk_{un}prepare() everytime fo

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > 2013/4/21 Tomasz Figa > > > Hi, > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > On 8 April 2013 16:37, Vikas Sajjan wrote: > > > > While migrating to common clock framework (CCF), I found that the > > > > FIMD

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > On 8 April 2013 16:37, Vikas Sajjan wrote: > > While migrating to common clock framework (CCF), I found that the FIMD > > clocks were pulled down by the CCF. > > If CCF finds any clock(s) which has NOT been claimed by any of the > > dr

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-08 Thread Viresh Kumar
On 8 April 2013 16:37, Vikas Sajjan wrote: > While migrating to common clock framework (CCF), I found that the FIMD clocks > were pulled down by the CCF. > If CCF finds any clock(s) which has NOT been claimed by any of the > drivers, then such clock(s) are PULLed low by CCF. > > Calling clk_prepar

[PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-08 Thread Vikas Sajjan
While migrating to common clock framework (CCF), I found that the FIMD clocks were pulled down by the CCF. If CCF finds any clock(s) which has NOT been claimed by any of the drivers, then such clock(s) are PULLed low by CCF. Calling clk_prepare() for FIMD clocks fixes the issue. This patch also r