Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-19 Thread Maxime Ripard
Hi! On Thu, Oct 18, 2018 at 03:46:05PM +0200, jacopo mondi wrote: > Hello Maxime, > > On Thu, Oct 18, 2018 at 11:29:12AM +0200, Maxime Ripard wrote: > > Hi Jacopo, > > > > Thanks for reviewing this patch > > > > On Tue, Oct 16, 2018 at 06:54:50PM +0200, jacopo mondi wrote: > > > > +static

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread Samuel Bobrowicz
> On Oct 18, 2018, at 3:03 AM, jacopo mondi wrote: > >> On Thu, Oct 18, 2018 at 11:31:52AM +0200, Maxime Ripard wrote: >>> On Wed, Oct 17, 2018 at 09:51:43PM +0200, jacopo mondi wrote: >>> Hello Sam and Maxime (and other ov5640-ers :) >>> On Wed, Oct 17, 2018 at 10:54:01AM -0700, Sam

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread Samuel Bobrowicz
Hey Jacobi, Not a lot of time to respond right now, these days I’m bouncing around between a couple jobs. I’ll be trying your and Maximes patches and responding to tech details this weekend. Just want to say that as long as we get the driver working I’m happy :) The VAST majority of time put

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread jacopo mondi
Hello Maxime, On Thu, Oct 18, 2018 at 11:29:12AM +0200, Maxime Ripard wrote: > Hi Jacopo, > > Thanks for reviewing this patch > > On Tue, Oct 16, 2018 at 06:54:50PM +0200, jacopo mondi wrote: > > > +static unsigned long ov5640_compute_sys_clk(struct ov5640_dev *sensor, > > > +

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread jacopo mondi
On Thu, Oct 18, 2018 at 11:31:52AM +0200, Maxime Ripard wrote: > On Wed, Oct 17, 2018 at 09:51:43PM +0200, jacopo mondi wrote: > > Hello Sam and Maxime (and other ov5640-ers :) > > > > On Wed, Oct 17, 2018 at 10:54:01AM -0700, Sam Bobrowicz wrote: > > > Hello Maxime and Jacopo (and other

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread Maxime Ripard
On Wed, Oct 17, 2018 at 09:51:43PM +0200, jacopo mondi wrote: > Hello Sam and Maxime (and other ov5640-ers :) > > On Wed, Oct 17, 2018 at 10:54:01AM -0700, Sam Bobrowicz wrote: > > Hello Maxime and Jacopo (and other ov5640-ers), > > > > I just submitted my version of this patch to the mailing

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread Maxime Ripard
Hi Jacopo, Thanks for reviewing this patch On Tue, Oct 16, 2018 at 06:54:50PM +0200, jacopo mondi wrote: > > +static unsigned long ov5640_compute_sys_clk(struct ov5640_dev *sensor, > > + u8 pll_prediv, u8 pll_mult, > > +

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-17 Thread jacopo mondi
Hello Sam and Maxime (and other ov5640-ers :) On Wed, Oct 17, 2018 at 10:54:01AM -0700, Sam Bobrowicz wrote: > Hello Maxime and Jacopo (and other ov5640-ers), > > I just submitted my version of this patch to the mailing list as RFC. > It is working on my MIPI platform. Please try it if you have

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-17 Thread Sam Bobrowicz
Hello Maxime and Jacopo (and other ov5640-ers), I just submitted my version of this patch to the mailing list as RFC. It is working on my MIPI platform. Please try it if you have time. Hopefully we can merge these two into a single patch that doesn't break any platforms. Thanks, Sam Additional

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-16 Thread jacopo mondi
Hello Maxime, a few comments I have collected while testing the series. Please see below. On Thu, Oct 11, 2018 at 11:20:56AM +0200, Maxime Ripard wrote: > The clock structure for the PCLK is quite obscure in the documentation, and > was hardcoded through the bytes array of each and every

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-15 Thread Hugues FRUCHET
Hi Maxime, I've recently found a problem around JPEG framerate, see below: On 10/11/2018 11:20 AM, Maxime Ripard wrote: > The clock structure for the PCLK is quite obscure in the documentation, and > was hardcoded through the bytes array of each and every mode. > > This is troublesome, since we

[PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-11 Thread Maxime Ripard
The clock structure for the PCLK is quite obscure in the documentation, and was hardcoded through the bytes array of each and every mode. This is troublesome, since we cannot adjust it at runtime based on other parameters (such as the number of bytes per pixel), and we can't support either