Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

2015-04-24 Thread Jacek Anaszewski
Hi Sakari, On Fri, 24 Apr 2015 00:52:12 +0300 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Jacek, Jacek Anaszewski wrote: ... +#define call_flash_op(v4l2_flash, op, arg) \ + (has_flash_op(v4l2_flash, op) ? \ +

Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

2015-04-24 Thread Sakari Ailus
Hi Jacek, On Fri, Apr 24, 2015 at 12:29:17PM +0200, Jacek Anaszewski wrote: Hi Sakari, On Fri, 24 Apr 2015 00:52:12 +0300 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Jacek, Jacek Anaszewski wrote: ... +#define call_flash_op(v4l2_flash, op, arg)\ +

Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

2015-04-23 Thread Jacek Anaszewski
On Thu, 23 Apr 2015 10:40:09 +0300 Hi Sakari, Thanks for the review. Sakari Ailus sakari.ai...@iki.fi wrote: Hi Jacek, On Wed, Apr 15, 2015 at 08:48:36AM +0200, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2

Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

2015-04-23 Thread Sakari Ailus
Hi Jacek, Jacek Anaszewski wrote: ... +#define call_flash_op(v4l2_flash, op, arg) \ + (has_flash_op(v4l2_flash, op) ? \ + v4l2_flash-ops-op(v4l2_flash, arg) : \ + -EINVAL) + +static enum

Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

2015-04-23 Thread Sakari Ailus
Hi Jacek, On Wed, Apr 15, 2015 at 08:48:36AM +0200, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash

[PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

2015-04-15 Thread Jacek Anaszewski
This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled in the kernel config the functions' empty versions will be