Re: [PATCH v6 3/5] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

2018-05-13 Thread Mauro Carvalho Chehab
Em Mon, 14 May 2018 03:13:44 +0900 Akihiro TSUKADA escreveu: > Hi, > thanks for the review. > > >> +gl861_i2c_rawwrite(struct dvb_usb_device *d, u8 addr, u8 *wbuf, u16 > >> wlen)>> +{>> +u8 *buf;>> +int ret;>> +>> +buf = > >> kmalloc(wlen, GFP_KERNEL);>> +if (!buf)>> +

Re: [PATCH v6 3/5] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

2018-05-13 Thread Akihiro TSUKADA
Hi, thanks for the review. >> +gl861_i2c_rawwrite(struct dvb_usb_device *d, u8 addr, u8 *wbuf, u16 wlen)>> >> +{>> + u8 *buf;>> +int ret;>> +>> +buf = kmalloc(wlen, >> GFP_KERNEL);>> +if (!buf)>> + return -ENOMEM;>> +>> + >> usleep_range(1000, 2000); /* avoid I2C erro

Re: [PATCH v6 3/5] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

2018-05-05 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 02:21:36 +0900 tsk...@gmail.com escreveu: > From: Akihiro Tsukada > > Friio device contains "gl861" bridge and "tc90522" demod, > for which the separate drivers are already in the kernel. > But friio driver was monolithic and did not use them, > practically copying those feat

[PATCH v6 3/5] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

2018-04-08 Thread tskd08
From: Akihiro Tsukada Friio device contains "gl861" bridge and "tc90522" demod, for which the separate drivers are already in the kernel. But friio driver was monolithic and did not use them, practically copying those features. This patch decomposes friio driver into sub drivers and re-uses exist